-
Notifications
You must be signed in to change notification settings - Fork 301
Update ReadMe to run creation, start worklows, along with arch.md file #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vishalbhatd123456
wants to merge
5
commits into
Netflix:main
Choose a base branch
from
vishalbhatd123456:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
010dfb0
Add repository architecture overview and diagram
vishalbhatd123456 6076f07
Merge pull request #1 from vishalbhatd123456/codex/analyze-repo-and-d…
vishalbhatd123456 6f513e6
Add guide for opening this change as upstream GitHub PR
vishalbhatd123456 1cb5f2c
Add local debug tips and minimal workflow example to README
vishalbhatd123456 46d3f18
Merge pull request #2 from vishalbhatd123456/codex/analyze-repo-and-d…
vishalbhatd123456 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Maestro Architecture Overview | ||
|
|
||
| This repository is a multi-module Gradle project for **Maestro**, a workflow orchestration platform. | ||
| At runtime, `maestro-server` composes the core engine, persistence, trigger systems, and pluggable step runtimes. | ||
|
|
||
| ## What the repo does (high-level) | ||
|
|
||
| - Exposes REST APIs to register workflows, start runs, inspect state, and operate instances. | ||
| - Stores workflow definitions, instances, and execution metadata in SQL-backed persistence. | ||
| - Executes workflows through a DAG/flow engine with internal queue-based job dispatch. | ||
| - Supports trigger-driven starts (time-based and signal-based). | ||
| - Supports pluggable runtime executors for step types (e.g., Kubernetes, HTTP). | ||
| - Includes optional AWS integrations (SQS/SNS based producers/queues). | ||
|
|
||
| ## Architecture picture | ||
|
|
||
| ```mermaid | ||
| flowchart TB | ||
| U[Users / SDK / CI] --> API[maestro-server\nSpring Boot API + wiring] | ||
|
|
||
| API --> DSL[maestro-dsl\nWorkflow DSL parsing] | ||
| API --> ENG[maestro-engine\nWorkflow orchestration] | ||
| API --> TRIG[maestro-timetrigger + maestro-signal\nTrigger processing] | ||
| API --> RT[Runtime Modules\nmaestro-kubernetes / maestro-http] | ||
|
|
||
| ENG --> FLOW[maestro-flow\nIn-memory flow progression] | ||
| ENG --> Q[maestro-queue\nDB-backed internal job queue] | ||
| ENG --> SEL[netflix-sel\nExpression evaluation] | ||
| ENG --> DB[maestro-database\nDAO + JDBC layer] | ||
|
|
||
| TRIG --> DB | ||
| Q --> DB | ||
| API --> DB | ||
| DB --> SQL[(Postgres / CockroachDB)] | ||
|
|
||
| RT --> EXT[External systems\nKubernetes API / HTTP endpoints] | ||
|
|
||
| AWS[maestro-aws\nOptional AWS adapters] -. provides .-> TRIG | ||
| AWS -. provides .-> Q | ||
| ``` | ||
|
|
||
| ## Module map | ||
|
|
||
| - **maestro-server**: app entrypoint, Spring configuration, REST controllers, request interceptors. | ||
| - **maestro-engine**: workflow runtime logic, job processors, action handlers, orchestration services. | ||
| - **maestro-flow**: high-performance flow progression primitive used by engine. | ||
| - **maestro-queue**: internal queue abstraction and workers for asynchronous event/job handling. | ||
| - **maestro-signal**: signal trigger/dependency model, DAOs, processors, queue producer interfaces. | ||
| - **maestro-timetrigger**: delayed trigger scheduling and execution processing. | ||
| - **maestro-database**: DB abstraction and shared JDBC helper/DAO support. | ||
| - **maestro-dsl**: workflow DSL model + parsing. | ||
| - **netflix-sel**: sandboxed expression language used in dynamic parameters/conditions. | ||
| - **maestro-kubernetes / maestro-http**: step runtime implementations. | ||
| - **maestro-aws**: optional implementations using AWS services (e.g., SNS/SQS). | ||
| - **maestro-common**: shared models, validation, utility classes, and exceptions. | ||
|
|
||
| ## Typical execution path | ||
|
|
||
| 1. Client submits workflow definition or action through `maestro-server` REST APIs. | ||
| 2. Workflow definition is parsed/validated (`maestro-dsl`, `maestro-common`). | ||
| 3. Engine persists state and enqueues/internal-dispatches job events (`maestro-engine`, `maestro-queue`, `maestro-database`). | ||
| 4. Flow progression executes steps (`maestro-flow`), evaluating expressions via `netflix-sel`. | ||
| 5. Step runtimes execute against external systems (`maestro-kubernetes`, `maestro-http`, etc.). | ||
| 6. Trigger modules (`maestro-timetrigger`, `maestro-signal`) can start new runs or unblock steps. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| ## Raise this change as a GitHub PR | ||
|
|
||
| You cannot open a PR directly from this environment unless your GitHub credentials are configured with push access. | ||
| Use this standard fork-and-PR flow against `https://github.com/Netflix/maestro`: | ||
|
|
||
| 1. Fork `Netflix/maestro` on GitHub to your account. | ||
| 2. Add your fork as `origin` and Netflix repo as `upstream`: | ||
| ```bash | ||
| git remote rename origin upstream | ||
| git remote add origin git@github.com:<your-user>/maestro.git | ||
| ``` | ||
| 3. Push your current branch: | ||
| ```bash | ||
| git push -u origin $(git branch --show-current) | ||
| ``` | ||
| 4. Open a PR in GitHub UI: | ||
| - Base repo: `Netflix/maestro` | ||
| - Base branch: `main` | ||
| - Compare repo: `<your-user>/maestro` | ||
| - Compare branch: your pushed branch | ||
| 5. Reuse this PR title/body: | ||
| - **Title:** `Add architecture overview and diagram for the Maestro repository` | ||
| - **Body:** summarize motivation, docs added, and testing notes. | ||
|
|
||
| ### Optional: create PR via GitHub CLI | ||
|
|
||
| If you have `gh` authenticated: | ||
|
|
||
| ```bash | ||
| gh pr create \ | ||
| --repo Netflix/maestro \ | ||
| --base main \ | ||
| --head <your-user>:$(git branch --show-current) \ | ||
| --title "Add architecture overview and diagram for the Maestro repository" \ | ||
| --body "Add architecture overview docs and Mermaid diagram; include validation notes." | ||
| ``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.