make MemoryDatabase.rebuildIndex public#1909
Merged
brharrington merged 1 commit intoJun 4, 2026
Merged
Conversation
Deriving index membership from the data map (Netflix#1906) stopped update() from feeding the index pending queue, so the synchronous data->index sync now happens only in rebuildIndex(). Callers that write via update() and previously forced a sync with index.rebuildIndex() no longer see their data: the no-arg BatchUpdateTagIndex.rebuildIndex() just drains an empty pending queue. Expose the unthrottled MemoryDatabase.rebuildIndex() so callers can force a synchronous rebuild after a bulk load or in tests. rebuild() remains the throttled variant used by the background thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deriving index membership from the data map (#1906) stopped update() from feeding the index pending queue, so the synchronous data->index sync now happens only in rebuildIndex(). Callers that write via update() and previously forced a sync with index.rebuildIndex() no longer see their data: the no-arg BatchUpdateTagIndex.rebuildIndex() just drains an empty pending queue.
Expose the unthrottled MemoryDatabase.rebuildIndex() so callers can force a synchronous rebuild after a bulk load or in tests. rebuild() remains the throttled variant used by the background thread.