feat: map split prop to cosmoz-resizable-view attributes#85
Merged
Conversation
🦋 Changeset detectedLatest commit: b7dfaeb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Convert split prop to initial-size/min-size attributes on cosmoz-resizable-view - split.sizes[0] → initial-size (percentage), split.minSize → min-size (px) - expandToMin and snapOffset silently ignored (no equivalent) - Default sizing: 50% / 100px - Remove CSS custom property approach (--cz-queue-list-basis, --cz-queue-list-min-width) - Add slot='previous' to list element via thru spread - Mark split prop @deprecated
megheaiulian
force-pushed
the
feat/split-prop-compat
branch
from
eac6336 to
b7dfaeb
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maps the
splitprop toinitial-size/min-sizeattributes on<cosmoz-resizable-view>instead of using CSS custom properties.Changes
split.sizes[0]→initial-sizeattribute (percentage)split.minSize→min-sizeattribute (px)expandToMinandsnapOffsetsilently ignored (no equivalent in flex model)50%/100px(matching split.js defaults)--cz-queue-list-basis,--cz-queue-list-min-width)slot='previous'to list element viathruspreadsplitprop marked@deprecatedDepends on
@neovici/cosmoz-resizablev2.2.0 (default slot redirect)