fix(api): validate numeric cursors and fix double-prefixed cache keys#1503
Merged
Conversation
- cursor params compared against bigint/numeric columns (account txns, receipts, stake txns, blocks, txns, chain-abstraction) accepted any string; a transaction hash passed as cursor reached Postgres and threw 'invalid input syntax for type bigint'. Validate digits-only at the schema boundary so clients get a 422 instead. - nb-redis cache() prefixed the key and then passed it to get/set, which prefix again — every cache entry was stored double-prefixed (prefix:prefix:key). Pass the raw key; stale double-prefixed entries age out via their TTLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.