Fix editor omicronBoost and add unknown property validation#59
Merged
NducTiOnomBi merged 4 commits intoApr 15, 2026
Merged
Conversation
- Rewrite ValidateCharacterData.ps1 to use module's Test-CharacterData instead of duplicating validation logic (~500 lines to ~210 lines) - Add synergy slot limit validation to Test-CharacterData - Add skipIfPresentCharacters cross-reference validation - Add character ID format validation (uppercase/numbers/underscores) - Fix single-element array unwrapping in ConvertTo-CharacterArray - Fix JSON array serialization for single validation errors in editor - Fix $Error variable conflict (eliminated with duplicate code removal) - Add test for JSON array serialization of single errors - All 60 Pester tests pass Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace hardcoded C:\ paths with cross-platform TestDrive paths so tests pass on both Windows and ubuntu-latest runners. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…alidation - Rename all omicronBoost references to omicronEnhancement in editor.js to match the JSON schema property name (was writing invalid property) - Fix case mismatch in getElementById calls that prevented omicron boost changes from enabling the Update Character button - Add unknown property validation to Test-CharacterData (catches properties not defined in the schema, e.g. omicronBoost on MAZKANATA) - Rename UI element IDs for consistency (inputomicronBoost→ inputomicronEnhancement, chkHasomicronBoost→chkHasomicronEnhancement) - Add Pester test for unknown property detection - All 61 tests pass Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Kept unknown property validation and test from this branch that were removed during merge with main (PR #58 changes). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
NducTiOnomBi
deleted the
feature/editor-fixes-and-unknown-property-validation
branch
April 15, 2026 05:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the visual editor writing to a non-existent
omicronBoostproperty (should beomicronEnhancementper schema) and adds validation to catch unknown properties.Changes
Bug Fixes (editor.js)
omicronBoostdata property references renamed toomicronEnhancementto match the JSON schema. The editor was previously reading/writing an invalid property name.chkHasOmicronBoost→chkHasomicronBoost(matching actual HTML element ID), which was preventing omicron changes from enabling the Update Character button.omicronBoosttoomicronEnhancementfor consistency.New Validation (VisualEditorFunctions.psm1)
Test-CharacterDatanow validates that character objects only contain properties defined in the schema. Catches typos and invalid properties likeomicronBoost.Tests
Validation
omicronEnhancementomicronBooston MAZKANATA is caught by validation