Fix "selected user is invalid" error when granting bundle to user with null name#388
Merged
Conversation
… name Filament's Select uses getOptionLabelUsing to validate the chosen value; returning a blank label causes the "in" rule to reject it. The bundle grant action returned `User->name`, which is null for some users. Use `getFilamentName()` so the label falls back through display_name, name, then email, ensuring a non-blank result for any existing user. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an admin tried to grant a plugin bundle to a user via the Filament
Bundlestable action, the form failed withThe selected user is invalidfor some users.Filament's
Selectvalidates the chosen value by callinggetOptionLabelUsing; if the callback returns a blank label, the implicitinrule rejects the value. The action's callback was returningUser::find($value)?->name, which isnullfor users without anameset, so otherwise-valid users couldn't be selected.Changes
getFilamentName()(which already falls back throughdisplay_name→name→email) in both the search results label andgetOptionLabelUsingcallback inapp/Filament/Resources/PluginBundleResource.php, guaranteeing a non-blank label for any existing user.name = null.Test plan
php artisan test --compact tests/Feature/Filament/GrantBundleToUserActionTest.phppasses (2 tests, 13 assertions)name = nullvia the Filament admin🤖 Generated with Claude Code