extraction-test :: move answer checking to IBaseDataObjectDiffHelper#1459
Open
dev-mlb wants to merge 1 commit into
Open
extraction-test :: move answer checking to IBaseDataObjectDiffHelper#1459dev-mlb wants to merge 1 commit into
dev-mlb wants to merge 1 commit into
Conversation
dev-mlb
force-pushed
the
extract-test-diff
branch
4 times, most recently
from
July 10, 2026 20:29
abb3f35 to
1e130f8
Compare
dev-mlb
changed the title
dev-mlb
force-pushed
the
extract-test-diff
branch
2 times, most recently
from
July 10, 2026 21:03
dd7e70a to
a68558a
Compare
dev-mlb
force-pushed
the
extract-test-diff
branch
from
July 11, 2026 11:07
a68558a to
089325c
Compare
dev-mlb
changed the title
cfkoehler
self-requested a review
July 16, 2026 09:31
cfkoehler
reviewed
Jul 18, 2026
| } | ||
| } | ||
|
|
||
| protected static boolean verifyOs(Element element, List<String> differences) { |
Collaborator
There was a problem hiding this comment.
Why not use OSReleaseUtil()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both ExtractionTest (lenient mode) and IBaseDataObjectDiffHelper (strict mode) contained separate answer-checking logic. This PR consolidates all answer-checking logic into IBaseDataObjectDiffHelper to eliminate duplication.
Key Changes
Note
This refactor focuses on consolidating calls while attempting to preserve backward compatibility. However, please watch for downstream code that may have overridden any of the relocated methods. Further refactoring will follow in subsequent PRs.