Migrate shared app components to shadcn tokens (v2.13.4) - #75
Open
NathanHealea wants to merge 9 commits into
Open
Migrate shared app components to shadcn tokens (v2.13.4)#75NathanHealea wants to merge 9 commits into
NathanHealea wants to merge 9 commits into
Conversation
Replace DaisyUI btn/rounded-box/rounded-btn/bg-base-* classes with a new menu.css dropdown layer (menu-dropdown, menu-dropdown-body, menu-item, menu-item-danger) built on shadcn tokens. Headless UI Menu interaction is unchanged. Covers every *-actions.tsx wrapper without further edits.
Add navbar.css (nav shell + brand) and extend menu.css with the DaisyUI menu list layer (menu, menu-horizontal, menu-title, divider). Replace base-100/200/300, base-content, error, and primary-content tokens with shadcn tokens. Headless UI Dialog interaction in mobile-nav is unchanged.
Restyle both Headless UI Menu dropdowns onto the shared menu-dropdown / menu-item token classes, dropping rounded-box/rounded-btn/bg-base-* and the btn-ghost/btn-error item styling. Menu interaction and auto-close unchanged.
Rebuild avatar.tsx on the doc-02 Avatar/AvatarImage/AvatarFallback primitive, dropping the hand-rolled markup and the bg-neutral/text-neutral-content tokens (placeholder styling now comes from avatar.css). Swap ring-offset-base-100 and text-error in image-upload for the background and destructive tokens.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc 03 of the UI Refactor epic (DaisyUI → shadcn/ui). Migrates the reusable app-level components in
src/components/off DaisyUI onto the doc-02 primitives and per-component token stylesheets. Headless UI stays the interaction layer for all dropdowns (not swapped to Radix),@heroicons/reactis kept, and daisyui remains installed (removed only in the final epic doc).*-actions.tsxwrappers) moved onto a newmenu.cssdropdown layer (menu-dropdown,menu-dropdown-body,menu-item,menu-item-danger);rounded-box/rounded-btn/bg-base-*gone.navbar.cssfor the nav shell/brand;menu.cssextended with the DaisyUI menu list layer (menu,menu-horizontal,menu-title,divider). Replacedbase-100/200/300,base-content,error, andprimary-contenttokens.menu-dropdown/menu-itemclasses; Headless UIMenuinteraction and auto-close unchanged.Avatar/AvatarImage/AvatarFallbackprimitive; placeholder styling now comes fromavatar.css(droppedbg-neutral/text-neutral-content).ring-offset-base-100→ring-offset-background,text-error→text-destructive;btnvariants use the token-based primitives.New stylesheets:
src/styles/components/menu.css,src/styles/components/navbar.css(both imported intoglobals.cssunderlayer(components)).Version
2.13.3 -> 2.13.4 (patch)
Test plan
npm run buildpassesnpm run lintpasses (0 errors; 6 pre-existing warnings, none in changed files)