feat/migrate windwatts-data to app backend#286
Open
sameersk2k wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues: #285 #281
Issue 281 backend is implemented, UI is pending.Changes
interpolationflag to easily control whether to support windspeed interpolation at diff heights for a given model.__init__make this as a package. It created a module level registry_lookupsthat maps model names with their lookup instances so it a singleton shared across the app and just loaded once. AthenaDataFetcher uses exported CKDTreeLookup class and register func to initialize instances. Irrespective of which algo is used (CDKTree or SparseLookup (future))athena fetcher will call find_nearest or find_n_nearest in spatial init.Concerns
grid index. Grid index is much better when dealing multiple concurrent API calls in future compared to on (lat, long) asgrid index (string)is reliable and accurate compared to floats. Instead of 1 df per (lat,long) why cant we cache multiple files pergrid index. But how many files should we cache? current is 100 maybe it should be decided on the file size which is 2KB per file forera5-quantiles2.8 KB forEnsemble Quantiles, 28 KBwtk-timeseries.Checklist
developmake formatandmake verifydevelopfeat/...,fix/...,docs/...,chore/...)feat: add new feature,fix: resolve bug,docs: update documentation)Others: e.g. Screenshots if UI change