Flatroof garage - #229
Merged
Merged
Conversation
…ver from pitched garage roofs.
- Move dev tools to PEP 735 [dependency-groups] so 'uv sync' installs them by default; add explicit pytest and pytest-cov - Switch CI to astral-sh/setup-uv with 'uv sync --locked' and 'uv run', fixing 'ruff: command not found' from the now-removed [dev] extra - Document uv-native install, development, and lint/format workflows in README; align Python version to >=3.10, <3.13
rajeee
approved these changes
Jun 4, 2026
rajeee
left a comment
rajeee
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor bugfix for flat garage roofs. Copied properties over from pitched roofs (and made sure those are up to date after double checking if the assembly R-value in hpxml files includes film coefficients, it does). I'm going to skip the issue since this falls under the larger issue of keeping up to date with ResStock.