Updates Kernal class with support for module configurations#4
Conversation
* This adds the ability to set specific configuration options for each of the modules loaded via the Kernel class `registerClasses` method. * It also supports the overriding of the default configuration values by passing in overrides from any extend class/theme kernel as outlined in the `README.md` file using any of the available options.
d062439 to
cf133aa
Compare
|
@harryfinn I'm not sure if this is really ready to implement into the code base. I think we could do something a bit tidier perhaps? Something like removing the auto inclusion of helper classes and then allow people to extend from them and use class specific setters to update the base configuration to add/ remove hooks. @jezemery what do you think on this one? I see where Finn is going with it and it does make sense I just think we need to think about the structure and implementation method a bit more? @harryfinn if you need this work to be implemented for an upcoming project I would suggest forking the repo and then applying your changes there in the mean time until we can get our heads together and come up with something a bit more inline with the ideals of what we are trying to do with NanoSoup. |
|
@HobbitCodes - yeah I agree, ideally want to get away from having everything loaded upfront and then having to switch things off. As you suggest, perhaps it would be the case of changing the purpose of the Kernel class to act as an interface to build out theme kernels, then include/extend the relevant supporting helper classes as needed, with the flexibility to add/remove hooks at those levels? |
This adds the ability to set specific configuration options for each
of the modules loaded via the Kernel class
registerClassesmethod.It also supports the overriding of the default configuration values by
passing in overrides from any extend class/theme kernel as outlined in the
README.mdfile using any of the available options.