Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

Feature/updating base files#137

Draft
harryfinn wants to merge 6 commits into
masterfrom
feature/updating-base-files
Draft

Feature/updating base files#137
harryfinn wants to merge 6 commits into
masterfrom
feature/updating-base-files

Conversation

@harryfinn

Copy link
Copy Markdown
Member

Updates to Erebus theme files and minor structure tweaks:

  • Removes .sass-lint.yml as requires ruby dependency and can be replaced by stylelint
  • Removes gulp file and associated base js and css files generated by the build process as now handled by webpack
  • Renames assets folders and add autoloads to images folder and use scss glob imports
  • Updates webpack config for javascript and stylesheets loading plus package dependencies

@harryfinn
harryfinn requested review from HobbitCodes and jezemery June 7, 2021 10:12
@harryfinn harryfinn self-assigned this Jun 7, 2021
@harryfinn
harryfinn marked this pull request as draft June 7, 2021 10:14

@jezemery jezemery left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@harryfinn

Copy link
Copy Markdown
Member Author

All looks good to me

Thanks @jezemery - have got some tweaks to Zeus to make too so will do a final test on both sets in a new project before making this PR 'active' again with a view to merge if all are happy

@HobbitCodes HobbitCodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing mental going on, looks good to me bud.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants