fix(ui): prevent chat from aggressively scrolling to bottom on slash …#591
Merged
will-lamerton merged 2 commits intoJun 27, 2026
Conversation
Dhirenderchoudhary
requested review from
Avtrkrb and
will-lamerton
as code owners
Dhirenderchoudhary
force-pushed
the
fix/581-chat-scroll-on-slash
branch
2 times, most recently
from
9d48b59 to
69f0974
Compare
akramcodez
reviewed
Jun 22, 2026
akramcodez
left a comment
akramcodez
left a comment
Collaborator
There was a problem hiding this comment.
great work @Dhirenderchoudhary, LGTM 👍
Member
|
Hey @Dhirenderchoudhary. Can you fix the conflict with main? Happy to merge when you have. Thanks :) |
…command Resolves Nano-Collective#581. Previously, rendering the slash command completions menu outside of the main bordered input <Box> altered the height of the live viewport area. This height change triggered Ink.js to recalculate flexbox layouts, forcing the chat history to unexpectedly snap to the bottom in smaller terminal windows. This commit moves the rendering of both command completions and file suggestions inside the bounded layout. The container expands naturally without disrupting the overall window height calculation, keeping the user's scroll position intact. Additionally: - Adds structural layout tests verifying completions render inside the container. - Fixes test timing flakes where simulated stdin input was occasionally ignored.
Dhirenderchoudhary
force-pushed
the
fix/581-chat-scroll-on-slash
branch
from
63ab8d2 to
b0ff723
Compare
Contributor
Author
|
@will-lamerton I've fixed the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #581.
Previously, rendering the slash command completions menu outside of the main bordered input
<Box>altered the height of the live viewport area. This height change triggered Ink.js to recalculate flexbox layouts, forcing the chat history to unexpectedly snap to the bottom in smaller terminal windows.This commit moves the rendering of both command completions and file suggestions inside the bounded layout. The container expands naturally without disrupting the overall window height calculation, keeping the user's scroll position intact.
Additionally:
Type of Change
Testing
Automated Tests
.spec.ts/tsxfilespnpm test:allcompletes successfully)Manual Testing
Checklist