Fix Windows file-locking error#86
Open
DrVinay wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, open file handles cannot be deleted, unlike Linux. System opened a temporary CSV log file but had no close() method, causing os.unlink() to fail in tests.
Changes made:
Added System.close() to system.py to release the CSV log handle
Updated test_create_system_registry.py to initialize system = None before try, then call system.close() in finally before unlinking the temp file.
This fixes the cross-platform inconsistency where tests passed in Linux CI but failed locally on Windows.