Clean up PR 232: Newton Python 3 fix and fatal diagnostics - #243
Merged
Conversation
Signed-off-by: Chen Tessler <ctessler@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #232.
Credit: this work builds directly on the original fixes and investigation contributed by @alexhegit in PR #232. Thank you for identifying the Python 3 Newton issue and the need for better fatal-crash diagnostics.
This follow-up keeps the substantive fixes while removing leftover debug instrumentation:
dict_keysview to a list before passing it toArticulationView.faulthandlerintrain_agent.pyfor native simulator/CUDA crash diagnostics.inference_agent.py.Verification:
match_labelsrejects the olddict_keysvalue withTypeErrorand accepts the list form.py_compile: passed.git diff --check: passed.The FK harness reports a pre-existing 0.000012 m tolerance-edge body-position discrepancy, but the Newton process initializes and runs successfully. No new dependencies are introduced.