Skip to content

fix(core): stop recommending maxBytesInFlight#2107

Draft
WilliamK112 wants to merge 1 commit into
NVIDIA:devfrom
WilliamK112:codex/remove-max-bytes-in-flight-recommendation
Draft

fix(core): stop recommending maxBytesInFlight#2107
WilliamK112 wants to merge 1 commit into
NVIDIA:devfrom
WilliamK112:codex/remove-max-bytes-in-flight-recommendation

Conversation

@WilliamK112

Copy link
Copy Markdown

What changed

Removes the AutoTuner recommendation for spark.rapids.shuffle.multiThreaded.maxBytesInFlight.

Why

Fixes #1710. The issue notes that this recommendation should be removed because it does not use metrics to make the decision, and the issue discussion has maintainer confirmation to remove it.

Details

  • Removed the MAX_BYTES_IN_FLIGHT tuning config and recommendation path from AutoTuner.
  • Simplified memory calculation to return only MemorySettings instead of carrying a maxBytesInFlight recommendation flag.
  • Updated profiling and qualification expected outputs to remove the recommended Spark property and reflect the reclaimed memory in pinned pool sizing.
  • Kept the tuning table Spark property entry so explicit user configs for that Spark key can still be recognized by the tuning metadata.

Validation

  • git diff --check
  • cd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.ProfilingAutoTunerSuiteV2 test
  • In a temporary worktree without spaces in the path:
    • cd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.QualificationAutoTunerSuite test
    • cd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.ProfilingAutoTunerSuite test

Note: the Qualification and legacy Profiling suites hit path-related failures from the local workspace path (New project) but passed from the temporary /tmp worktree with the same patch applied.

Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
@github-actions github-actions Bot added the core_tools Scope the core module (scala) label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core_tools Scope the core module (scala)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AutoTuner: Remove recommendation for maxBytesInFlight

2 participants