fix(core): stop recommending maxBytesInFlight#2107
Draft
WilliamK112 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the AutoTuner recommendation for
spark.rapids.shuffle.multiThreaded.maxBytesInFlight.Why
Fixes #1710. The issue notes that this recommendation should be removed because it does not use metrics to make the decision, and the issue discussion has maintainer confirmation to remove it.
Details
MAX_BYTES_IN_FLIGHTtuning config and recommendation path fromAutoTuner.MemorySettingsinstead of carrying amaxBytesInFlightrecommendation flag.Validation
git diff --checkcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.ProfilingAutoTunerSuiteV2 testcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.QualificationAutoTunerSuite testcd core && JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -DwildcardSuites=com.nvidia.spark.rapids.tool.tuning.ProfilingAutoTunerSuite testNote: the Qualification and legacy Profiling suites hit path-related failures from the local workspace path (
New project) but passed from the temporary/tmpworktree with the same patch applied.