Skip to content

Add Skill Card Generator#88

Merged
mosheabr merged 3 commits into
NVIDIA:mainfrom
pmaiti-nvidia:main
May 28, 2026
Merged

Add Skill Card Generator#88
mosheabr merged 3 commits into
NVIDIA:mainfrom
pmaiti-nvidia:main

Conversation

@pmaiti-nvidia
Copy link
Copy Markdown
Member

@pmaiti-nvidia pmaiti-nvidia commented May 26, 2026

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: _____
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

Signed-off-by: Pratyusha Maiti <pmaiti@nvidia.com>
@pmaiti-nvidia
Copy link
Copy Markdown
Member Author

@mosheabr - cross referencing previous comment: https://github.com/NVIDIA/skills/pull/64#issuecomment-4500645275

Please let me know if any questions or concerns!

@Patrick-Erichsen
Copy link
Copy Markdown

Thanks for opening this @pmaiti-nvidia! Will land this in https://github.com/openclaw/clawhub once shipped.

Signed-off-by: Pratyusha Maiti <pmaiti@nvidia.com>
- catalog_dir: lowercase to match skill name (flat-layout policy adopted
  2026-05-28 — skills land at skills/<skill-name>/ at top level, no
  product parent dir)
- name: drop hyphens — "Skill Card Generator" (display name); slug
  derivation still produces skill-card-generator.yml
- Add trailing slash to source path for consistency
- links.discussions: false — Trustworthy-AI has Discussions disabled;
  without override the auto-generated Getting Help table renders a
  broken link

Signed-off-by: Moshe Abramovitch <moshea@nvidia.com>
Copy link
Copy Markdown
Collaborator

@mosheabr mosheabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Skill Card Generator from NVIDIA/Trustworthy-AI is the cleanest onboarding to date: source-side PR #13 landed all 5 prereqs (renamed skill-card.md, evals.json, signed, SPDX license, bonus BENCHMARK.md from re-running /nvskills-ci after Keshav's announcement). Catalog yml now follows flat-layout convention (lowercase catalog_dir matching skill name) and overrides discussions for the Trustworthy-AI repo that has them disabled. Per-skill LICENSE file present — exactly the right pattern for a CC0 source repo carrying Apache-2.0/CC-BY-4.0 skill content.

@mosheabr mosheabr merged commit c6204c1 into NVIDIA:main May 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants