Skip to content

chore(ci): use explicit secrets where possible #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gforsyth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ci): use explicit secrets where possible #3042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: build

@gforsyth gforsyth May 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace changes are a result of using yq to bulk-edit the workflow files. The loss of the whitespace isn't my first choice, but I think it's a reasonable trade-off for what yq allows us to do, especially when making bulk edits across repositories.

on:
push:
branches:
Expand Down Expand Up @@ -27,13 +26,10 @@ on:
description: "build_type: one of [branch, nightly, pull-request]"
type: string
default: nightly

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: true

permissions: {}

jobs:
cpp-build:
permissions:
Expand Down Expand Up @@ -77,7 +73,9 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
secrets:
CONDA_RAPIDSAI_NIGHTLY_TOKEN: ${{ secrets.CONDA_RAPIDSAI_NIGHTLY_TOKEN }}
CONDA_RAPIDSAI_TOKEN: ${{ secrets.CONDA_RAPIDSAI_TOKEN }}
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
Expand Down Expand Up @@ -132,7 +130,9 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
secrets:
CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN: ${{ secrets.CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN }}
RAPIDSAI_PYPI_TOKEN: ${{ secrets.RAPIDSAI_PYPI_TOKEN }}
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
Expand Down Expand Up @@ -170,7 +170,9 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
secrets:
CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN: ${{ secrets.CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN }}
RAPIDSAI_PYPI_TOKEN: ${{ secrets.RAPIDSAI_PYPI_TOKEN }}
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
Expand Down Expand Up @@ -209,7 +211,9 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
secrets:
CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN: ${{ secrets.CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN }}
RAPIDSAI_PYPI_TOKEN: ${{ secrets.RAPIDSAI_PYPI_TOKEN }}
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
Expand All @@ -221,7 +225,7 @@ jobs:
publish-wheel-search-key: raft_dask_wheel_python_abi3
devcontainers:
name: Build devcontainers
secrets: inherit # zizmor: ignore[secrets-inherit]
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/build-devcontainers.yaml@main
permissions:
packages: write
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main
if: always()
with:
Expand Down Expand Up @@ -76,7 +75,6 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@main
with:
files_yaml: |
Expand Down Expand Up @@ -189,7 +187,6 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@main
with:
enable_check_generated_files: false
Expand Down Expand Up @@ -230,7 +227,6 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@main
with:
build_type: pull-request
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: test

on:
workflow_dispatch:
inputs:
Expand All @@ -21,9 +20,7 @@ on:
description: "build_type: one of [branch, nightly, pull-request]"
type: string
default: nightly

permissions: {}

jobs:
conda-cpp-checks:
permissions:
Expand All @@ -32,7 +29,6 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@main
with:
build_type: ${{ inputs.build_type }}
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/trigger-breaking-change-alert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: Trigger Breaking Change Notifications

# `zizmor` always flags these triggers because they are easy to use
# incorrectly. These usages are ok and don't execute any PR-specific
# code (and so aren't susceptible to exploits from forked PRs)
Expand All @@ -10,7 +9,6 @@ on: # zizmor: ignore[dangerous-triggers]
- reopened
- labeled
- unlabeled

jobs:
trigger-notifier:
if: contains(github.event.pull_request.labels.*.name, 'breaking')
Expand All @@ -20,7 +18,8 @@ jobs:
id-token: write
packages: read
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
secrets:
NV_SLACK_BREAKING_CHANGE_ALERT: ${{ secrets.NV_SLACK_BREAKING_CHANGE_ALERT }}
uses: rapidsai/shared-workflows/.github/workflows/breaking-change-alert.yaml@main
with:
sender_login: ${{ github.event.sender.login }}
Expand Down
Loading