Update IB enablement guidance#2450
Open
hasayesh wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-2450.docs.buildwithfern.com/infra-controller |
## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [X] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Description Clarifies Infiniband enablement guidance by documenting that `[ib_config]` starts the IB fabric manager and IB fabric monitor, removes the separate `[ib_fabric_monitor]` enablement example, and adds commented UFM endpoint and PKey range examples to the Helm prereq values. ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [X] No testing required (docs and commented configuration examples only) ## Additional Notes Signed-off-by: Hamid Asayesh <hasayesh@nvidia.com>
hasayesh
force-pushed
the
update-ib-enable-guidance
branch
from
aa8efe5 to
8fc517e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Clarifies Infiniband enablement guidance by documenting that
[ib_config]starts the IB fabric manager and IB fabric monitor, removes the separate[ib_fabric_monitor]enablement example, and adds commented UFM endpoint and PKey range examples to the Helm prereq values.Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes