Skip to content

feat: hardware-health fetch non sensor data metrics#2433

Open
yoks wants to merge 3 commits into
NVIDIA:mainfrom
yoks:health-nta-parity
Open

feat: hardware-health fetch non sensor data metrics#2433
yoks wants to merge 3 commits into
NVIDIA:mainfrom
yoks:health-nta-parity

Conversation

@yoks

@yoks yoks commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Right now HW health only fetches sensor backed data, but some metrics are explosed as scalar or other values via Metrics endpoint.

This PR adds support for all default metrics. Next steps would be to add OEM metrics support (as soon as they added to nv-redfish).

PR refactors discovery to separate task which uses ArcSwap to share data between collectors. Metrics collector would be disabled by default for now.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

#2283

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@yoks yoks requested a review from a team as a code owner June 10, 2026 22:00
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b62a490b-d231-41e2-a58e-eb0c362b65cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

@zhaozhongn

Copy link
Copy Markdown
Contributor

Would this further increase the BMC workload and potentially degrade its performance for DPS use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants