feat: hardware-health fetch non sensor data metrics#2433
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-2433.docs.buildwithfern.com/infra-controller |
|
Would this further increase the BMC workload and potentially degrade its performance for DPS use case? |
Description
Right now HW health only fetches sensor backed data, but some metrics are explosed as scalar or other values via Metrics endpoint.
This PR adds support for all default metrics. Next steps would be to add OEM metrics support (as soon as they added to nv-redfish).
PR refactors discovery to separate task which uses
ArcSwapto share data between collectors. Metrics collector would be disabled by default for now.Type of Change
Related Issues (Optional)
#2283
Breaking Changes
Testing
Additional Notes