Skip to content

chore: Clean up cloud-unsafe-op logic in admin-cli#2430

Open
kensimon wants to merge 1 commit into
NVIDIA:mainfrom
kensimon:admin-cli-unsafe-op-cleanup
Open

chore: Clean up cloud-unsafe-op logic in admin-cli#2430
kensimon wants to merge 1 commit into
NVIDIA:mainfrom
kensimon:admin-cli-unsafe-op-cleanup

Conversation

@kensimon

Copy link
Copy Markdown
Contributor

Description

We were writing the same error message over and over, just make it a CarbideCliError variant instead. Also, drop the unnecessary instance::common::GlobalOptions struct because it's totally redundant to the existing RuntimeContext struct.

This also fixes a bug where you'd type --cloud-unsafe-op="my_username" and it would end up logging "Unsafe cloud operation performed by: enabled" instead of the username you typed.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

We were writing the same error message over and over, just make it a
CarbideCliError variant instead. Also, drop the unnecessary
instance::common::GlobalOptions struct because it's totally redundant to
the existing RuntimeContext struct.
@kensimon kensimon requested a review from a team as a code owner June 10, 2026 21:21
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2b24f248-0c38-45f4-a626-d4576a7d263b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants