Allow seeding carbide-api-config with VPCs#2416
Conversation
This makes things a little easier to configure for sites where there's just one flat subnet with DPU-less hosts, by allowing you to configure VPC definitions in the config TOML, and attaching a `vpc_name` property to network definitions. You can now configure the necessary network topology for a working, flat, zero-dpu network in the config file.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| fn source_description(cfg: &CarbideConfig, name: &str) -> String; | ||
| } | ||
|
|
||
| impl SeedKind for NetworkDefinition { |
There was a problem hiding this comment.
Thanks for doing this. As I was working on NetworkDefinition I thought, "This should be a trait, if we have to convert one more resource over to initial_objects.toml, I'm going to make a trait for this."
You beat me to it
|
Other than the lint-police complaints, it LGTM |
2 participants
Description
This makes things a little easier to configure for sites where there's just one flat subnet with DPU-less hosts, by allowing you to configure VPC definitions in the config TOML, and attaching a
vpc_nameproperty to network definitions. You can now configure the necessary network topology for a working, flat, zero-dpu network in the config file.Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes