Skip to content

chore(rest-api): Migrate AllocationConstraint and Domain DAOs to use param structs#2363

Open
nvlitagaki wants to merge 4 commits into
NVIDIA:mainfrom
nvlitagaki:chore/constraint-dao
Open

chore(rest-api): Migrate AllocationConstraint and Domain DAOs to use param structs#2363
nvlitagaki wants to merge 4 commits into
NVIDIA:mainfrom
nvlitagaki:chore/constraint-dao

Conversation

@nvlitagaki

Copy link
Copy Markdown
Contributor

Description

This refactor updates the AllocationConstraint and Domain DAOs to use more convenient structs for parameters rather than accepting a ton of different params.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@nvlitagaki nvlitagaki requested a review from a team as a code owner June 10, 2026 17:25
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 53c8037f-5152-48a9-8858-7990735d6581

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-06-10 17:27:44 UTC | Commit: 17f970d

@nvlitagaki nvlitagaki marked this pull request as draft June 10, 2026 17:50
@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@nvlitagaki nvlitagaki marked this pull request as ready for review June 10, 2026 19:26
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
nico-flow 126 14 54 44 5 9
nico-nsm 133 11 45 66 11 0
nico-psm 128 14 56 44 5 9
nico-rest-api 192 17 88 70 8 9
nico-rest-cert-manager 105 6 51 35 4 9
nico-rest-db 126 14 54 44 5 9
nico-rest-site-agent 125 14 54 44 4 9
nico-rest-site-manager 112 7 52 40 4 9
nico-rest-workflow 128 14 56 44 5 9
TOTAL 1175 111 510 431 51 72

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant