Skip to content

feat(vsock): DCGM-5059 Add VSOCK standalone routing via dcgmConnect_v3#128

Merged
rvatkar merged 1 commit into
mainfrom
rvatkar/feat/DCGM-5059-vsock-connect-v3
Jun 3, 2026
Merged

feat(vsock): DCGM-5059 Add VSOCK standalone routing via dcgmConnect_v3#128
rvatkar merged 1 commit into
mainfrom
rvatkar/feat/DCGM-5059-vsock-connect-v3

Conversation

@rvatkar

@rvatkar rvatkar commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Adds dcgmConnect_v3 support for standalone DCGM connection strings in go-dcgm.
This change detects supported DCGM URI schemes:

tcp://
unix://
vsock://

When dcgm.Init(dcgm.Standalone, ) receives one supported URI argument, it routes through dcgmConnect_v3. Existing legacy standalone calls, such as host/port plus socket flag, continue to use the existing dcgmConnect_v2 path.

Validation

  • Added unit coverage for VSOCK, TCP, UNIX, uppercase schemes, legacy host/socket flag behavior, missing socket flag behavior, and unsupported scheme fallthrough.
  • Added runtime symbol guard for dcgmConnect_v3 to return a clear error if the deployed libdcgm.so.4 is too old.
  • Verified locally:
    • go test ./pkg/dcgm -count=1

Notes

  • Requires runtime DCGM library version that exports dcgmConnect_v3.
  • This MR preserves existing dcgmConnect_v2 behavior for legacy standalone connection arguments.

@rvatkar rvatkar changed the title feat(vsock): DCGM-5059 Add VSOCK standalone routing via dcgmConnect_v3 Draft: feat(vsock): DCGM-5059 Add VSOCK standalone routing via dcgmConnect_v3 Jun 1, 2026
@rvatkar rvatkar changed the title Draft: feat(vsock): DCGM-5059 Add VSOCK standalone routing via dcgmConnect_v3 feat(vsock): DCGM-5059 Add VSOCK standalone routing via dcgmConnect_v3 Jun 1, 2026
@rvatkar rvatkar requested a review from nccurry June 1, 2026 23:05

@nccurry nccurry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvatkar rvatkar merged commit 453d821 into main Jun 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants