Fix DCGM group cleanup on watch and health error paths#122
Merged
Conversation
nccurry
reviewed
May 20, 2026
nccurry
requested changes
May 20, 2026
nccurry
previously approved these changes
May 20, 2026
Collaborator
|
Applies to go-dcgm/tests/processinfo_test.go Lines 21 to 23 in a47f5c5 The PR added non-root-aware coverage for the new package tests, but the existing process-info tests still hard-fail when |
nccurry
reviewed
May 22, 2026
nccurry
reviewed
May 22, 2026
nccurry
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DCGM group lifecycle issues:
healthCheckByGpuId.watchPidFields.WatchFields.UpdateAllFieldserrors fromWatchFieldsandwatchPidFields, matchingWatchFieldsWithGroupEx.getProcessInfo.The watch helpers now clean up only on failure and preserve group ownership on success. PID-watch DCGM errors still return
*dcgm.Error, and the conditionalgetSupportedDevices()path is unchanged.Tests
go test ./pkg/dcgm -run 'Test(GroupCapErrorMatcher|HealthCheckByGpuIdDoesNotLeakGroupOnError|WatchFieldsDoesNotLeakGroupOnError|WatchPidFieldsDoesNotLeakGroupOnError| WatchPidFieldsDoesNotLeakGroupOnNonRootWatchError|WatchFieldsDoesNotDestroyGroupOnSuccess|WatchPidFieldsDoesNotDestroyGroupOnSuccess|WatchFieldsReturnsUpdateAllFieldsErrorAndDestroysGroup| WatchPidFieldsReturnsUpdateAllFieldsErrorAndDestroysGroup)' -count=1 -vgo test ./samples/restApi/... -count=1