helm: allow overriding probe timeoutSeconds/failureThreshold#679
Open
ChenZiHong-Gavin wants to merge 1 commit into
Open
helm: allow overriding probe timeoutSeconds/failureThreshold#679ChenZiHong-Gavin wants to merge 1 commit into
ChenZiHong-Gavin wants to merge 1 commit into
Conversation
Signed-off-by: Zihong Chen <522023320011@smail.nju.edu.cn>
Author
|
@nccurry @daphne2337 @jay-mckay @glowkey @guptaNswati Please review this PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expose
timeoutSecondsandfailureThreshold(plusreadinessProbe.periodSeconds)as optional values on the liveness and readiness probes in the DaemonSet chart.
Why
The chart currently only templatizes
initialDelaySecondsand (for liveness)periodSeconds. It never setstimeoutSecondsorfailureThreshold, so thekubelet defaults apply:
timeoutSeconds: 1,failureThreshold: 3.The liveness probe hits
/healthover HTTP. On busy nodes that endpoint can takelonger than 1s to respond; three consecutive >1s responses trip the default
failureThreshold: 3and the kubelet kills an otherwise-healthy container(graceful exit 0, not OOM), which then restarts and can repeat — a false-kill /
crashloop. Today there is no values-based way to loosen the probe; the only
options are vendoring the chart or post-rendering the manifest.
This adds the missing knobs so operators can set e.g.
timeoutSeconds: 5/failureThreshold: 5(see #612 for a report of the same symptom).How
The new fields are rendered with
{{- with ... }}, so when they are unset thetemplate emits nothing and the kubelet defaults continue to apply. Existing
installations see no change unless they explicitly set the new values.
Validation
helm templatewith no overrides: rendered probes are byte-for-byte unchanged(no
timeoutSeconds/failureThresholdemitted).helm templatewith the new values set: fields render correctly on both thehttpGetandbasicAuthtcpSocketprobe branches.helm lint: passes.