grafana: show Hostname in dashboard legends for multi-node clusters#672
Open
75asu wants to merge 1 commit into
Open
grafana: show Hostname in dashboard legends for multi-node clusters#67275asu wants to merge 1 commit into
75asu wants to merge 1 commit into
Conversation
…cross nodes Signed-off-by: Asutosh Panda <asutosh.pda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #630.
In a multi-node cluster the bundled dashboard's per-GPU legends collide: every node shows
GPU 0,GPU 1, ... with no way to tell them apart (see the screenshot in the issue). This prepends theHostnamelabel so each series reads<hostname> GPU <n>.Only the 6 per-GPU panels are changed; the cluster-wide avg/sum panels (empty legend) are left as-is.
Format is open to preference -- happy to use
{{instance}}instead of{{Hostname}}, or a different separator, if the maintainers prefer.