Skip to content

Add missing visibility controls in IVF SQ #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 1 commit into from
May 29, 2026
+11 −4
Merged

Add missing visibility controls in IVF SQ #2141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions c/include/cuvs/neighbors/ivf_sq.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <stdbool.h>
#include <stdint.h>

#include <cuvs/core/export.h>

#ifdef __cplusplus
extern "C" {
#endif
Expand Down
13 changes: 9 additions & 4 deletions cpp/include/cuvs/neighbors/ivf_sq.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include "common.hpp"
#include <cstdint>
#include <cuvs/core/export.hpp>
#include <cuvs/distance/distance.hpp>
#include <cuvs/neighbors/common.hpp>
#include <raft/core/device_mdarray.hpp>
Expand All @@ -15,7 +16,9 @@
#include <raft/core/mdspan.hpp>
#include <raft/util/integer_utils.hpp>

namespace cuvs::neighbors::ivf_sq {
namespace CUVS_EXPORT cuvs {
namespace neighbors {
namespace ivf_sq {

/**
* @defgroup ivf_sq_cpp_index_params IVF-SQ index build parameters
Expand Down Expand Up @@ -86,7 +89,7 @@ static_assert(std::is_aggregate_v<search_params>);
*/

template <typename SizeT, typename CodeT, typename IdxT>
struct list_spec {
struct CUVS_EXPORT list_spec {
static_assert(std::is_same_v<CodeT, uint8_t>, "IVF-SQ code type CodeT must be uint8_t");

using value_type = CodeT;
Expand Down Expand Up @@ -166,7 +169,7 @@ using list_data = ivf::list<list_spec, SizeT, CodeT, IdxT>;
*
*/
template <typename CodeT>
struct index : cuvs::neighbors::index {
struct CUVS_EXPORT index : cuvs::neighbors::index {
static_assert(std::is_same_v<CodeT, uint8_t>, "IVF-SQ code type CodeT must be uint8_t for now.");

using index_params_type = ivf_sq::index_params;
Expand Down Expand Up @@ -625,4 +628,6 @@ void deserialize(raft::resources const& handle,
* @}
*/

} // namespace cuvs::neighbors::ivf_sq
} // namespace ivf_sq
} // namespace neighbors
} // namespace CUVS_EXPORT cuvs
Loading