[WIP] Retire CagraIndexParamsFactory to use CuVS's internal heuristicAPI, Add ParamsBase for common parameters#156
Draft
narangvivek10 wants to merge 5 commits into
Conversation
…plication purposes
…raIndexParams from utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes to:
CagraIndexParamsFactoryto use CuVS's internal heuristic API as planned before. Now withStrategy.HEURISTICas the default recommended strategy, we will be able to tune indexes with the standard beam width and max connection parameters, and the CAGRA's parameters, like graph degree, intermediate graph degree, are automatically estimated internally. This is now applicable for both - Index on GPU and search on CPU, and index and search on the GPU APIs.ParamsBaseclass for bringing common input parameters in one base class for code deduplication inAcceleratedHNSWParamsandGPUSearchParams.Fixes #149
Fixes #127