Upgrade lucene to 10.4#153
Open
punAhuja wants to merge 3 commits into
Open
Conversation
- Fixes NVIDIA#114 - Mainly code deduplication by plugging in `AcceleratedHNSWUtils` and some rearrangement. - Summary of code changes: - Update `AcceleratedHNSWParams` to incorporate feedback suggestions from NVIDIA#120 and update Javadocs. - Update `AcceleratedHNSWUtils` to be able to plug into `Lucene99AcceleratedHNSWVectorsWriter`. `AcceleratedHNSWUtils` is meant to contain common logic for `Lucene99AcceleratedHNSWVectorsWriter`, `LuceneAcceleratedHNSWBinaryQuantizedVectorsWriter`, and `LuceneAcceleratedHNSWScalarQuantizedVectorsWriter`. - Update `QuantizedFieldWriter` to `FieldWriter` as it can be used for all three mentioned above. - Update `Lucene101AcceleratedHNSWCodec` to add some javadocs. - Update `Lucene99AcceleratedHNSWVectorsFormat` to plug in the number of merge workers and an instance of `TaskExecutor` used for the fallback mechanism, and some variable renaming. - Update `Lucene99AcceleratedHNSWVectorsWriter` to remove methods that are now in the `AcceleratedHNSWUtils`, remove some unused/obsolete code, remove some CAGRA merge API related methods that are not currently used and planned to be taken as a separate task, variable renaming, and update documentation. - Update `LuceneAcceleratedHNSWBinaryQuantizedVectorsWriter` to use the now renamed `FieldWriter`. - Update `LuceneAcceleratedHNSWScalarQuantizedVectorsWriter` to use the now renamed `FieldWriter`. - Update `Utils` to move a common method `createListFromMergedVectors`. - Update `TestAcceleratedHNSWParams` to adapt to the feedback suggestion code changes from NVIDIA#120. Authors: - Vivek Narang (https://github.com/narangvivek10) Approvers: - MithunR (https://github.com/mythrocks) URL: NVIDIA#115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Lucene to 10.4 for release/26.04
This PR upgrades Lucene from 10.2.0 to 10.4.0 while maintaining cuVS 26.04.0 compatibility for the release/26.04 branch.
Changes:
Includes necessary API refactoring (AcceleratedHNSW improvements) that the Lucene upgrade depends on
Updates all Lucene dependencies to 10.4.0
Adapts to Lucene 10.4 API changes (AcceptDocs, GroupVarInt encoding)