cuvs-lucene-137: increase max-number of HNSW layers in CAGRA_HNSW's conversion from CAGRA to HNSW#140
Open
nvzm123 wants to merge 2 commits into
Open
cuvs-lucene-137: increase max-number of HNSW layers in CAGRA_HNSW's conversion from CAGRA to HNSW#140nvzm123 wants to merge 2 commits into
nvzm123 wants to merge 2 commits into
Conversation
…onversion from CAGRA to HNSW
narangvivek10
added
improvement
Contributor
|
@nvzm123 thanks for opening this PR. Can you please attach benchmarks that demonstrate the value of the change and show that it's an improvement (and doesn't cause regressions)? |
cjnolet
approved these changes
Jun 11, 2026
Contributor
|
/ok to test 0629b15 |
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The natural number of HNSW layers is ln(segment_size)/ln(graph_degree), which is often around 6, yet we had a constraint that was limiting us to a maximum of 3 HNSW layers. This change effectively makes the maximum number of layers unbounded.