[None][test] Stabilize scaffolding OpenAI worker tests#16853
Draft
Mgluhovskoi wants to merge 1 commit into
Draft
[None][test] Stabilize scaffolding OpenAI worker tests#16853Mgluhovskoi wants to merge 1 commit into
Mgluhovskoi wants to merge 1 commit into
Conversation
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Contributor
Author
|
/bot run |
Collaborator
|
PR_Github #61653 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #61653 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
GenerationTask.create_from_prompt()leavesmax_tokensunset. In a recent CI failure, the gpt-oss-20b request was accepted but continued until the OpenAI client's 600-second timeout. The failure handler then terminated the module-scoped server, causing the following chat test to fail against the same dead server.Bounding the request matches the existing chat test and keeps this test focused on verifying successful worker generation. Fixture-owned teardown preserves pytest fail-fast behavior while preventing cascading failures and ensuring cleanup after the module.
Impact
Test-only change. Production behavior is unaffected.
Validation
python3 -m py_compile tests/unittest/scaffolding/test_worker.pyThe model-backed test requires the TensorRT-LLM GPU CI environment and was not run locally.