Skip to content

[None][fix] Preserve HF checkpoint fallback errors #16846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

[None][fix] Preserve HF checkpoint fallback errors #16846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tensorrt_llm/_torch/models/checkpoints/hf/weight_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,7 @@ def _load_bin_or_path_file(file):
weights_only=True,
map_location='cpu',
mmap=False)
finally:
return part_weights
return part_weights

def _prefetch_one_file(self, file_name):
if os.path.exists(file_name):
Expand Down
17 changes: 17 additions & 0 deletions tests/unittest/_torch/models/checkpoints/hf/test_weight_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,23 @@ def test_load_weights_ignores_consolidated_ckpt_when_sharded_ckpt_exists(
assert set(loaded_weight_files) == expected_safetensor_filenames


def test_bin_loader_propagates_fallback_error():
loader = HfWeightLoader()
with (
mock.patch(
"tensorrt_llm._torch.models.checkpoints.hf.weight_loader.torch.load",
side_effect=[OSError("mmap failed"), MyError("fallback failed")],
) as torch_load,
pytest.raises(MyError, match="fallback failed"),
):
loader._load_bin_or_path_file("model.bin")

assert torch_load.call_args_list == [
mock.call("model.bin", weights_only=True, map_location="cpu", mmap=True),
mock.call("model.bin", weights_only=True, map_location="cpu", mmap=False),
]


def test_weight_cache_reuses_raw_weights_with_fresh_consumable_wrapper(tmp_path, monkeypatch):
monkeypatch.setenv("TRTLLM_HF_WEIGHT_CACHE", "1")

Expand Down