Skip to content

[https://nvbugs/6501376][fix] Test-only fix — drop the if hidden_size % 2 != 0: with pytest.raises(...)… #16844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trtllm-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −14
Open

[https://nvbugs/6501376][fix] Test-only fix — drop the if hidden_size % 2 != 0: with pytest.raises(...)… #16844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions tests/unittest/_torch/multi_gpu/test_linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,13 +286,8 @@ def test_column_linear(hidden_size, mpi_pool_executor):
run_single_rank,
*zip(*[(tensor_parallel_size, column_linear_forward, x, [l0_weight],
hidden_size, dtype)] * 2))
if hidden_size % 2 != 0:
with pytest.raises(AssertionError):
for r in results:
assert r is True
else:
for r in results:
assert r is True
for r in results:
assert r is True


@pytest.mark.skipif(torch.cuda.device_count() < 2,
Expand All @@ -311,13 +306,8 @@ def test_row_linear(hidden_size, mpi_pool_executor):
run_single_rank,
*zip(*[(tensor_parallel_size, row_linear_forward, x, [l0_weight],
hidden_size, dtype)] * 2))
if hidden_size % 2 != 0:
with pytest.raises(AssertionError):
for r in results:
assert r is True
else:
for r in results:
assert r is True
for r in results:
assert r is True


@pytest.mark.skipif(torch.cuda.device_count() < 2,
Expand Down
Loading