[None][infra] Unwaive test_proxy_fast_death tests#16808
Conversation
Signed-off-by: Derek Pitman <dpitman@nvidia.com>
|
/bot skip --comment "Unwaive only" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoves the waiver entries that skipped ChangesIntegration waiver cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #61378 [ skip ] triggered by Bot. Commit: |
|
PR_Github #61378 [ skip ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #61414 [ run ] triggered by Bot. Commit: |
|
/bot kill |
|
PR_Github #61415 [ kill ] triggered by Bot. Commit: |
|
PR_Github #61414 [ run ] completed with state |
|
PR_Github #61415 [ kill ] completed with state |
|
/bot skip --comment "Unwaive only, previous run was an accident" |
|
PR_Github #61419 [ skip ] triggered by Bot. Commit: |
|
PR_Github #61419 [ skip ] completed with state |
BowenFu
left a comment
There was a problem hiding this comment.
LGTM — waiver-removal-only change re-enabling test_proxy_fast_death tests after the nvbugs/6499882 fix. No product/test-source or CI changes; only re-enables coverage.
Dev Engineer Review
unittest/executor/test_proxy_fast_death.py.QA Engineer Review
tests/integration/test_lists/waives.txt; removed thetest_proxy_fast_deathwaiver entries.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.