[https://nvbugs/6448152][perf] TEST ONLY; DO NOT REVIEW: diagnose PP consensus traffic#16487
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
3618ba3 to
1522ea7
Compare
|
/bot run --disable-fail-fast --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
|
PR_Github #59681 [ run ] triggered by Bot. Commit: |
|
PR_Github #59681 [ run ] completed with state
|
|
/bot run --disable-fail-fast --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
|
PR_Github #59735 [ run ] triggered by Bot. Commit: |
|
PR_Github #59735 [ run ] completed with state
|
Caution
DIAGNOSTIC ONLY — DO NOT MERGE.
Purpose
Determine whether runtime/per-request C++ PP context-transfer consensus traffic is the dominant cause of NVBUG 6448152's throughput regression.
This branch is a range-equivalent replay of #16386 and diagnostic PR #16449 onto current
main(4188dbe330) so Jenkins can construct a merge commit. Original #16449 head91935fccorresponds to rebased commit656873e; this PR replaces that early-local-completion arm with a stronger no-hot-traffic arm.graph LR A["current main"] --> B["#16386 replay: worker-published consensus"] B --> C["#16449 replay: early local completion diagnostic"] C --> D["this PR: no runtime/per-request PP consensus traffic"]Diagnostic behavior
When
TRTLLM_DIAGNOSTIC_DISABLE_PP_CONTEXT_CONSENSUS_TRAFFIC=1on the qualified C++ NIXL/UCX TP1/CP1 PP path:ContextTransferVoteMailboxis constructed;The exact GB300 perf-sanity YAML enables the flag. The PP4 TinyLlama integration test requires this runtime marker on every CTX PP worker:
What remains
This does not remove all PP communication:
The experiment isolates the context-transfer runtime consensus mailbox, not the whole PP stack.
Interpretation
Historical comparison points:
If this result remains near 800, runtime mailbox sends/polls plus consensus-state retention are not the dominant regression, and two-phase lifecycle or admission-control investigation should take priority over transport redesign.
If throughput materially recovers, the result justifies redesigning the C++ consensus transport. It would not distinguish packet/poll cost from retained-state retirement/cleanup, because this arm removes both.
Because this PR runs on newer
mainthan the historical #16449 result, a surprising delta must be confirmed with a same-base #16449 control run before attribution.Validation
GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1