[TRTLLM-14388][refactor] BREAKING: Remove 2-model code and tests by mikeiovine · Pull Request #16380 · NVIDIA/TensorRT-LLM

mikeiovine · 2026-07-14T16:39:22Z

Description

Remove 2-model code and related tests. We are past the deprecation period and all feature gaps have been closed.

Some 2-model code is left behind for a few niche things that can't use 1-model (ngram, user-provided).

Test Coverage

Existing tests.

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

Consolidates speculative decoding around the one-model EAGLE3/MTP execution path and removes deprecated two-model implementation, including ModelDrafter, MTPDraftModel, separate draft-engine orchestration, and related CUDA-graph/KV-cache handling.
Removes deprecated public configuration flags and enum members such as eagle3_one_model, mtp_eagle_one_model, draft-engine memory types, and one-model mode variants. This is API-breaking and requires downstream configuration updates.
Retains niche two-model support for N-gram and user-provided drafters.
Updates mode dispatch, samplers, metadata, resource managers, attention backends, model constructors, validation, examples, documentation, and benchmark configurations for the unified modes.
Removes obsolete tests and updates remaining tests, baselines, QA lists, waivers, and test-duration keys to match renamed parameters and test cases.
Verify API compatibility, all call sites for changed signatures, speculative-mode routing, dynamic-tree behavior, KV-cache accounting, CUDA-graph capture, and error handling. Confirm generated formatter/legacy allowlists are correct.
CI follow-up is required: completed runs for fb94cd2, e6bb6c9, and f917b0b failed in the L0 merge-request pipeline; investigate, fix, and rerun with NVIDIA-team ownership.

QA Engineer Review

Modified test code covers EAGLE3, MTP, speculative metadata, KV-cache reuse, CUDA graphs, draft-length scheduling, disaggregated serving, AutoDeploy, model loading, metrics, and executor behavior. Obsolete two-model MTP and draft-token tree tests were removed; remaining tests were updated to use unified configuration names.

Modified test-list and QA files include:

tests/integration/test_lists/test-db/l0_b200.yml
tests/integration/test_lists/test-db/l0_dgx_b200.yml
tests/integration/test_lists/test-db/l0_dgx_h100.yml
tests/integration/test_lists/test-db/l0_gb200_multi_gpus.yml
tests/integration/test_lists/test-db/l0_h100.yml
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
tests/integration/test_lists/qa/llm_function_core.txt
tests/integration/test_lists/qa/llm_function_rtx6k.txt
tests/integration/test_lists/qa/llm_spark_func.yml
tests/integration/test_lists/waives.txt

Entries were renamed or replaced to remove one_model/two_model variants, and obsolete two-model coverage was removed. Test paths and parameter formats should be validated against collected pytest node IDs, with no duplicate or unintentionally lost coverage.

Verdict: needs follow-up pending investigation of the failed L0 CI runs and confirmation of CBTS coverage.

mikeiovine · 2026-07-14T16:41:11Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-07-14T16:47:03Z

PR_Github #59235 [ run ] triggered by Bot. Commit: 95afa29 Link to invocation

tensorrt-cicd · 2026-07-14T19:40:22Z

PR_Github #59235 [ run ] completed with state ABORTED. Commit: 95afa29

Link to invocation

mikeiovine · 2026-07-16T18:06:34Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-07-16T18:24:08Z

PR_Github #59758 [ run ] triggered by Bot. Commit: 97e26c8 Link to invocation

mikeiovine · 2026-07-16T20:08:40Z

/bot run --disable-fail-fast

QiJune

LGTM

tensorrt-cicd · 2026-07-17T00:10:06Z

PR_Github #59775 [ run ] completed with state SUCCESS. Commit: fb94cd2
/LLM/main/L0_MergeRequest_PR pipeline #48200 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

mikeiovine · 2026-07-17T15:01:39Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-07-17T15:08:01Z

PR_Github #59996 [ run ] triggered by Bot. Commit: e6bb6c9 Link to invocation

tensorrt-cicd · 2026-07-17T19:37:11Z

PR_Github #59996 [ run ] completed with state FAILURE. Commit: e6bb6c9
/LLM/main/L0_MergeRequest_PR pipeline #48389 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

mikeiovine · 2026-07-23T20:11:33Z

/bot run

tensorrt-cicd · 2026-07-23T20:18:04Z

PR_Github #61388 [ run ] triggered by Bot. Commit: f917b0b Link to invocation

tensorrt-cicd · 2026-07-23T20:57:11Z

PR_Github #61388 [ run ] completed with state FAILURE. Commit: f917b0b
/LLM/main/L0_MergeRequest_PR pipeline #49615 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Mike Iovine <miovine@nvidia.com>

Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>

Signed-off-by: Mike Iovine <miovine@nvidia.com>

mikeiovine · 2026-07-24T18:58:04Z

/bot run

tensorrt-cicd · 2026-07-24T19:04:34Z

PR_Github #61624 [ run ] triggered by Bot. Commit: eedbdef Link to invocation

coderabbitai

🧹 Nitpick comments (1)

tensorrt_llm/_torch/attention_backend/sparse/dsa.py (1)
1531-1541: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Per-step pinned host buffer allocation in a hot path.

host_block_table is freshly allocated (with pin_memory=prefer_pinned()) on every call to prepare_for_indexer_k_cache, which runs every forward step via prepare(). Every sibling staging buffer in this class (host_indexer_k_cache_block_offsets, host_slot_mapping_fp8, etc.) is pre-allocated once in create_buffers_for_indexer/__post_init__ and reused. Repeated pinned-memory allocation/free is a comparatively costly page-locking operation on a per-forward-step path.
♻️ Suggested fix: pre-allocate a persistent staging buffer
-        # pool_indices already has correct values; set padding to -1.
-        # Stage through a fresh pinned buffer: an async H2D from pageable
-        # memory would block the host behind the busy execution stream.
-        host_block_table = torch.empty((pool_indices.shape[0], max_blocks_used),
-                                       dtype=pool_indices.dtype,
-                                       pin_memory=prefer_pinned())
-        host_block_table.copy_(pool_indices[:, :max_blocks_used])
+        # pool_indices already has correct values; set padding to -1.
+        # Stage through a persistent pinned buffer (allocated once in
+        # create_buffers_for_indexer) to avoid a per-step pinned alloc.
+        host_block_table = self.host_block_table_staging[:pool_indices.shape[0], :max_blocks_used]
+        host_block_table.copy_(pool_indices[:, :max_blocks_used])
And add a self.host_block_table_staging buffer of shape [max_num_sequences, max_blocks_per_seq] alongside the other persistent host buffers in create_buffers_for_indexer.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tensorrt_llm/_torch/attention_backend/sparse/dsa.py` around lines 1531 -
1541, Pre-allocate a persistent host_block_table_staging buffer in
create_buffers_for_indexer (or the corresponding __post_init__ setup) with shape
[max_num_sequences, max_blocks_per_seq], matching pool_indices’ dtype and
pinned-memory policy. Update prepare_for_indexer_k_cache to reuse this buffer
for copying and padding instead of allocating host_block_table on every call,
while preserving the existing per-step contents and masking behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tensorrt_llm/_torch/attention_backend/sparse/dsa.py`:
- Around line 1531-1541: Pre-allocate a persistent host_block_table_staging
buffer in create_buffers_for_indexer (or the corresponding __post_init__ setup)
with shape [max_num_sequences, max_blocks_per_seq], matching pool_indices’ dtype
and pinned-memory policy. Update prepare_for_indexer_k_cache to reuse this
buffer for copying and padding instead of allocating host_block_table on every
call, while preserving the existing per-step contents and masking behavior.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ba4defc3-cdbf-42a2-905c-473d215f6d0f

📥 Commits

Reviewing files that changed from the base of the PR and between f917b0b and eedbdef.

📒 Files selected for processing (83)

.pre-commit-config.yaml
docs/source/blogs/tech_blog/blog06_Llama4_maverick_eagle_guide.md
docs/source/features/torch_compile_and_piecewise_cuda_graph.md
docs/source/legacy/advanced/speculative-decoding.md
examples/auto_deploy/model_registry/configs/super_v3_mtp.yaml
examples/llm-api/llm_speculative_decoding.py
examples/llm-api/quickstart_advanced.py
examples/models/core/deepseek_v4/README.md
examples/models/core/exaone/README.md
examples/models/core/mistral_large_3/README.md
examples/models/core/nemotron/README_nemotron_super_v3.md
legacy-files.txt
pyproject.toml
ruff-legacy.toml
tensorrt_llm/_torch/attention_backend/interface.py
tensorrt_llm/_torch/attention_backend/sparse/dsa.py
tensorrt_llm/_torch/attention_backend/trtllm.py
tensorrt_llm/_torch/auto_deploy/llm_args.py
tensorrt_llm/_torch/auto_deploy/shim/ad_executor.py
tensorrt_llm/_torch/models/modeling_auto.py
tensorrt_llm/_torch/models/modeling_deepseekv3.py
tensorrt_llm/_torch/models/modeling_glm.py
tensorrt_llm/_torch/models/modeling_nemotron_h.py
tensorrt_llm/_torch/models/modeling_qwen3vl.py
tensorrt_llm/_torch/models/modeling_speculative.py
tensorrt_llm/_torch/pyexecutor/_util.py
tensorrt_llm/_torch/pyexecutor/cuda_graph_runner.py
tensorrt_llm/_torch/pyexecutor/model_engine.py
tensorrt_llm/_torch/pyexecutor/model_loader.py
tensorrt_llm/_torch/pyexecutor/py_executor.py
tensorrt_llm/_torch/pyexecutor/py_executor_creator.py
tensorrt_llm/_torch/pyexecutor/sampler/sampler.py
tensorrt_llm/_torch/speculative/__init__.py
tensorrt_llm/_torch/speculative/drafter.py
tensorrt_llm/_torch/speculative/drafting_loops.py
tensorrt_llm/_torch/speculative/eagle3.py
tensorrt_llm/_torch/speculative/interface.py
tensorrt_llm/_torch/speculative/model_drafter.py
tensorrt_llm/_torch/speculative/mtp.py
tensorrt_llm/_torch/speculative/utils.py
tensorrt_llm/llmapi/llm_args.py
tensorrt_llm/usage/llm_args_golden_manifest.json
tests/integration/defs/.test_durations
tests/integration/defs/.test_durations_aws_dfw
tests/integration/defs/accuracy/test_disaggregated_serving.py
tests/integration/defs/accuracy/test_llm_api_autodeploy.py
tests/integration/defs/accuracy/test_llm_api_pytorch.py
tests/integration/defs/disaggregated/test_ad_disagg.py
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2_gentp2_gptoss_eagle_triton.yaml
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2_gentp2_gptoss_eagle_trtllm.yaml
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py
tests/integration/defs/examples/serve/test_spec_decoding_metrics.py
tests/integration/defs/examples/test_ad_speculative_decoding.py
tests/integration/defs/perf/pytorch_model_config.py
tests/integration/defs/perf/test_perf_sanity.py
tests/integration/defs/test_e2e.py
tests/integration/test_lists/qa/llm_function_core.txt
tests/integration/test_lists/qa/llm_function_rtx6k.txt
tests/integration/test_lists/qa/llm_spark_func.yml
tests/integration/test_lists/test-db/l0_b200.yml
tests/integration/test_lists/test-db/l0_dgx_b200.yml
tests/integration/test_lists/test-db/l0_dgx_h100.yml
tests/integration/test_lists/test-db/l0_gb200_multi_gpus.yml
tests/integration/test_lists/test-db/l0_h100.yml
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
tests/integration/test_lists/waives.txt
tests/scripts/perf-sanity/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/scripts/perf-sanity/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tests/scripts/perf-sanity/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/scripts/perf-sanity/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tests/scripts/perf/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/scripts/perf/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tests/scripts/perf/disaggregated/gb200_stress-gpt-oss-120b-fp4_8k1k_ctx1_tp1_gen1_tp4_eplb0_eagle3_ccb-NIXL.yaml
tests/scripts/perf/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/scripts/perf/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tests/unittest/_torch/attention/sparse/deepseek_v4/test_deepseek_v4_cache_manager.py
tests/unittest/_torch/executor/test_dual_pool_kv_cache.py
tests/unittest/_torch/executor/test_kv_cache_estimation.py
tests/unittest/_torch/executor/test_model_loader_mx.py
tests/unittest/_torch/executor/test_py_executor.py
tests/unittest/_torch/executor/test_seq_slot_sizing.py
tests/unittest/_torch/helpers.py
tests/unittest/_torch/modeling/test_modeling_llama.py

💤 Files with no reviewable changes (34)

tests/unittest/_torch/executor/test_dual_pool_kv_cache.py
examples/auto_deploy/model_registry/configs/super_v3_mtp.yaml
tests/scripts/perf-sanity/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2_gentp2_gptoss_eagle_triton.yaml
tensorrt_llm/_torch/speculative/drafting_loops.py
legacy-files.txt
tensorrt_llm/_torch/models/modeling_auto.py
pyproject.toml
tests/integration/defs/perf/pytorch_model_config.py
examples/models/core/nemotron/README_nemotron_super_v3.md
tensorrt_llm/usage/llm_args_golden_manifest.json
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2_gentp2_gptoss_eagle_trtllm.yaml
tests/integration/defs/disaggregated/test_ad_disagg.py
examples/llm-api/quickstart_advanced.py
examples/models/core/mistral_large_3/README.md
tests/scripts/perf-sanity/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/unittest/_torch/executor/test_kv_cache_estimation.py
tests/scripts/perf/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/integration/test_lists/test-db/l0_b200.yml
tests/scripts/perf/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/unittest/_torch/helpers.py
tensorrt_llm/_torch/attention_backend/interface.py
.pre-commit-config.yaml
tests/unittest/_torch/modeling/test_modeling_llama.py
tensorrt_llm/_torch/speculative/model_drafter.py
tests/scripts/perf/disaggregated/gb300_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tests/integration/defs/perf/test_perf_sanity.py
ruff-legacy.toml
tests/scripts/perf-sanity/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb416_mtp3_ccb-NIXL.yaml
tests/scripts/perf-sanity/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml
tensorrt_llm/_torch/models/modeling_nemotron_h.py
tests/scripts/perf/disaggregated/gb200_stress-gpt-oss-120b-fp4_8k1k_ctx1_tp1_gen1_tp4_eplb0_eagle3_ccb-NIXL.yaml
tests/integration/defs/test_e2e.py
tests/scripts/perf/disaggregated/gb200_kimi-k25-thinking-fp4_8k1k_con4_ctx1_dep4_gen1_tep8_eplb0_mtp3_ccb-NIXL.yaml

🚧 Files skipped from review as they are similar to previous changes (30)

docs/source/blogs/tech_blog/blog06_Llama4_maverick_eagle_guide.md
docs/source/features/torch_compile_and_piecewise_cuda_graph.md
tensorrt_llm/_torch/auto_deploy/shim/ad_executor.py
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py
tests/unittest/_torch/attention/sparse/deepseek_v4/test_deepseek_v4_cache_manager.py
tests/unittest/_torch/executor/test_seq_slot_sizing.py
tests/integration/test_lists/qa/llm_spark_func.yml
tensorrt_llm/_torch/auto_deploy/llm_args.py
tensorrt_llm/_torch/speculative/drafter.py
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
tests/integration/test_lists/test-db/l0_dgx_h100.yml
tests/integration/test_lists/qa/llm_function_rtx6k.txt
tests/integration/defs/.test_durations_aws_dfw
tests/unittest/_torch/executor/test_py_executor.py
tensorrt_llm/_torch/pyexecutor/sampler/sampler.py
tensorrt_llm/_torch/speculative/mtp.py
tests/integration/defs/accuracy/test_llm_api_autodeploy.py
tests/integration/defs/examples/test_ad_speculative_decoding.py
tensorrt_llm/_torch/pyexecutor/cuda_graph_runner.py
tensorrt_llm/_torch/models/modeling_deepseekv3.py
tests/integration/test_lists/test-db/l0_dgx_b200.yml
tensorrt_llm/_torch/speculative/interface.py
tests/integration/test_lists/test-db/l0_h100.yml
tensorrt_llm/_torch/models/modeling_speculative.py
tests/integration/test_lists/qa/llm_function_core.txt
tensorrt_llm/_torch/pyexecutor/py_executor_creator.py
tensorrt_llm/llmapi/llm_args.py
tensorrt_llm/_torch/speculative/utils.py
tests/integration/defs/accuracy/test_llm_api_pytorch.py
tensorrt_llm/_torch/pyexecutor/model_engine.py

tensorrt-cicd · 2026-07-24T21:33:19Z

PR_Github #61624 [ run ] completed with state SUCCESS. Commit: eedbdef
/LLM/main/L0_MergeRequest_PR pipeline #49831 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

mikeiovine added the api-breaking Accepted LLM API contract change that is backwards-incompatible label Jul 14, 2026

github-actions Bot assigned mikeiovine Jul 14, 2026

mikeiovine force-pushed the remove-2-model branch 6 times, most recently from 4764a86 to 97e26c8 Compare July 16, 2026 18:03

mikeiovine force-pushed the remove-2-model branch from 97e26c8 to dd496c8 Compare July 16, 2026 19:29

mikeiovine changed the title ~~[None][chore] BREAKING: Remove 2-model code and tests~~ [None][refactor] BREAKING: Remove 2-model code and tests Jul 16, 2026

mikeiovine changed the title ~~[None][refactor] BREAKING: Remove 2-model code and tests~~ [TRTLLM-14388][refactor] BREAKING: Remove 2-model code and tests Jul 16, 2026

mikeiovine force-pushed the remove-2-model branch 3 times, most recently from 4807177 to cfe1571 Compare July 16, 2026 19:44

mikeiovine force-pushed the remove-2-model branch from cfe1571 to fb94cd2 Compare July 16, 2026 20:10

mikeiovine marked this pull request as ready for review July 16, 2026 20:12

mikeiovine requested review from a team as code owners July 16, 2026 20:12

cascade812 reviewed Jul 16, 2026

View reviewed changes

Comment thread examples/llm-api/quickstart_advanced.py

cascade812 reviewed Jul 16, 2026

View reviewed changes

Comment thread tests/integration/test_lists/waives.txt Outdated

cascade812 reviewed Jul 16, 2026

View reviewed changes

Comment thread tensorrt_llm/_torch/pyexecutor/_util.py Outdated

cascade812 reviewed Jul 16, 2026

View reviewed changes

Comment thread tensorrt_llm/_torch/speculative/utils.py

cascade812 approved these changes Jul 16, 2026

View reviewed changes

Tabrizian approved these changes Jul 16, 2026

View reviewed changes

QiJune approved these changes Jul 17, 2026

View reviewed changes

mikeiovine force-pushed the remove-2-model branch 4 times, most recently from 39ad75d to e6bb6c9 Compare July 17, 2026 14:58

LarryXFly approved these changes Jul 20, 2026

View reviewed changes

VALLIS-NERIA approved these changes Jul 21, 2026

View reviewed changes

mikeiovine force-pushed the remove-2-model branch from e6bb6c9 to 9bec289 Compare July 23, 2026 19:25

coderabbitai Bot mentioned this pull request Jul 23, 2026

[None][feat] Add Qwen3-based DSpark drafter (DeepSpec dense checkpoints) #16813

Open

1 task

mikeiovine and others added 3 commits July 24, 2026 14:57

[None][chore] Remove 2-model code and tests

5c460e7

Signed-off-by: Mike Iovine <miovine@nvidia.com>

[None][fix] Remove stale MTP mode argument

f09cfd2

Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>

Fix lints

eedbdef

Signed-off-by: Mike Iovine <miovine@nvidia.com>

mikeiovine force-pushed the remove-2-model branch from f917b0b to eedbdef Compare July 24, 2026 18:57

coderabbitai Bot reviewed Jul 24, 2026

View reviewed changes

Uh oh!

Conversation

mikeiovine commented Jul 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

PR Checklist

GitHub Bot Help

Dev Engineer Review

QA Engineer Review

Uh oh!

mikeiovine commented Jul 14, 2026

Uh oh!

tensorrt-cicd commented Jul 14, 2026

Uh oh!

tensorrt-cicd commented Jul 14, 2026

Uh oh!

mikeiovine commented Jul 16, 2026

Uh oh!

tensorrt-cicd commented Jul 16, 2026

Uh oh!

mikeiovine commented Jul 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QiJune left a comment

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commented Jul 17, 2026

Uh oh!

mikeiovine commented Jul 17, 2026

Uh oh!

tensorrt-cicd commented Jul 17, 2026

Uh oh!

tensorrt-cicd commented Jul 17, 2026

Uh oh!

mikeiovine commented Jul 23, 2026

Uh oh!

tensorrt-cicd commented Jul 23, 2026

Uh oh!

tensorrt-cicd commented Jul 23, 2026

Uh oh!

mikeiovine commented Jul 24, 2026

Uh oh!

tensorrt-cicd commented Jul 24, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mikeiovine commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading