Skip to content

[None][infra] Unwaive test_proxy_fast_death tests#16808

Merged
dpitman-nvda merged 2 commits into
NVIDIA:mainfrom
dpitman-nvda:unwaive-proxy-fast-death
Jul 24, 2026
Merged

[None][infra] Unwaive test_proxy_fast_death tests#16808
dpitman-nvda merged 2 commits into
NVIDIA:mainfrom
dpitman-nvda:unwaive-proxy-fast-death

Conversation

@dpitman-nvda

@dpitman-nvda dpitman-nvda commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the module and test-specific waivers for unittest/executor/test_proxy_fast_death.py.
  • The waiver list remains correctly formatted, with no unintended changes or duplicate entries.
  • No code, API, performance, or error-handling changes.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt; removed the test_proxy_fast_death waiver entries.
  • No test-db or QA coverage data was provided.
  • Verdict: needs follow-up.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Derek Pitman <dpitman@nvidia.com>
@dpitman-nvda

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Unwaive only"

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7831af05-b26a-458c-b4ca-df35ae939f02

📥 Commits

Reviewing files that changed from the base of the PR and between 526c1e3 and 8ceb2a2.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removes the waiver entries that skipped unittest/executor/test_proxy_fast_death.py and its test cases from the integration test waiver list.

Changes

Integration waiver cleanup

Layer / File(s) Summary
Remove proxy fast-death waivers
tests/integration/test_lists/waives.txt
Removes the module and test-case SKIP entries for unittest/executor/test_proxy_fast_death.py.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: qijune

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the template boilerplate and omits the actual issue, solution, and test coverage details. Add a short Description and Test Coverage section that explains why the waivers were removed and what tests validate the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required ticket/type/summary format and matches the waiver removal change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61378 [ skip ] triggered by Bot. Commit: 8ceb2a2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61378 [ skip ] completed with state SUCCESS. Commit: 8ceb2a2
Skipping testing for commit 8ceb2a2

Link to invocation

@dpitman-nvda
dpitman-nvda enabled auto-merge (squash) July 23, 2026 20:02
@dpitman-nvda

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61414 [ run ] triggered by Bot. Commit: e06e5fd Link to invocation

@dpitman-nvda

Copy link
Copy Markdown
Collaborator Author

/bot kill

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61415 [ kill ] triggered by Bot. Commit: e06e5fd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61414 [ run ] completed with state ABORTED. Commit: e06e5fd

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61415 [ kill ] completed with state SUCCESS. Commit: e06e5fd
Successfully killed previous jobs for commit e06e5fd

Link to invocation

@dpitman-nvda

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Unwaive only, previous run was an accident"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61419 [ skip ] triggered by Bot. Commit: e06e5fd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61419 [ skip ] completed with state SUCCESS. Commit: e06e5fd
Skipping testing for commit e06e5fd

Link to invocation

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — waiver-removal-only change re-enabling test_proxy_fast_death tests after the nvbugs/6499882 fix. No product/test-source or CI changes; only re-enables coverage.

@dpitman-nvda
dpitman-nvda merged commit 35134c2 into NVIDIA:main Jul 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants