feat: add skill-load coverage for agent integrations [2/3]#392
feat: add skill-load coverage for agent integrations [2/3]#392willkill07 wants to merge 5 commits into
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
License DiffCompared against Lockfile license changesLockfile License ChangesRustAdded
Removed
Updated/Changed
NodeAdded
Removed
Updated/Changed
PythonAdded
Removed
Updated/Changed
Status output |
|
I’d drop the OpenClaw-specific skill-load handling from this stack. With the CLI/sidecar pivot, extending hook replay with eager/fallback state looks like unnecessary complexity. I’d keep the shared core and other integration changes, remove the corresponding OpenClaw changes from 392/393, and handle managed OpenClaw skill marks at the sidecar boundary if we still need them. That would also make my OpenClaw-specific inline comments moot. |
UserPromptExpansion is only present in Claude Code's plugin hook whitelist from 2.1.116. Older hosts reject the entire plugin hooks file on the unknown event name and silently load no relay hooks, for both the transparent-run temp plugin and the marketplace plugin. Document the verified floor on HOOK_EVENTS, make doctor warn when the probed Claude Code predates it, and state the requirement in the plugin README. Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com> (cherry picked from commit d3b8959)
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
89db64d to
4a09ce7
Compare
Overview
Extends RELAY-443 coverage into the supported agent integrations. This is the second commit in a three-PR cumulative stack; all three PRs target upstream
mainas requested, so this PR temporarily includes the first commit until it merges.Details
srctrees.Validation:
just test-rust,just test-python,just test-node, anduv run pre-commit run --all-files.Breaking changes: none.
Where should the reviewer start?
Start with
crates/core/src/api/skill_load.rs, then review the coding-agent hook configurations and Python integration coverage.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)