Skip to content

feat: add skill-load coverage for agent integrations [2/3]#392

Draft
willkill07 wants to merge 5 commits into
NVIDIA:mainfrom
willkill07:wkk_relay-443-integrations
Draft

feat: add skill-load coverage for agent integrations [2/3]#392
willkill07 wants to merge 5 commits into
NVIDIA:mainfrom
willkill07:wkk_relay-443-integrations

Conversation

@willkill07

@willkill07 willkill07 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Overview

Extends RELAY-443 coverage into the supported agent integrations. This is the second commit in a three-PR cumulative stack; all three PRs target upstream main as requested, so this PR temporarily includes the first commit until it merges.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Adds skill-load hook coverage for the Claude Code and Codex coding-agent integrations.
  • Adds real LangChain, LangGraph, and Deep Agents coverage while preserving the existing Deep Agents configured-skills mark.
  • Keeps all test bodies outside implementation src trees.
  • Removes all OpenClaw changes; that integration work will be refactored separately.

Validation: just test-rust, just test-python, just test-node, and uv run pre-commit run --all-files.

Breaking changes: none.

Where should the reviewer start?

Start with crates/core/src/api/skill_load.rs, then review the coding-agent hook configurations and Python integration coverage.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: RELAY-443

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 requested a review from a team as a code owner July 8, 2026 23:42
@github-actions github-actions Bot added size:XL PR is extra large Feature a new feature lang:js PR changes/introduces Javascript/Typescript code lang:python PR changes/introduces Python code lang:rust PR changes/introduces Rust code labels Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 24c1677d-74d7-4586-8e9a-85994dc34620

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@willkill07 willkill07 added this to the 0.6 milestone Jul 8, 2026
@willkill07 willkill07 self-assigned this Jul 8, 2026
@willkill07 willkill07 marked this pull request as draft July 8, 2026 23:44
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

License Diff

Compared against origin/main.

Lockfile license changes

Lockfile License Changes

Rust

Added

  • None

Removed

  • None

Updated/Changed

  • None

Node

Added

  • None

Removed

  • None

Updated/Changed

  • None

Python

Added

  • None

Removed

  • None

Updated/Changed

  • None
Status output
[license-diff] selected languages: rust, node, python
[license-diff] generating current inventory
[license-diff] current: generating Rust inventory
[license-diff] current: Rust inventory complete (378 packages)
[license-diff] current: generating Node inventory
[license-diff] current: Node inventory complete (363 packages)
[license-diff] current: generating Python inventory
[license-diff] current: Python inventory complete (105 packages)
[license-diff] current inventory complete
[license-diff] checking out base ref origin/main into a temporary worktree
[license-diff] base: generating Rust inventory
[license-diff] base: Rust inventory complete (378 packages)
[license-diff] base: generating Node inventory
[license-diff] base: Node inventory complete (363 packages)
[license-diff] base: generating Python inventory
[license-diff] base: Python inventory complete (105 packages)
[license-diff] base inventory complete
[license-diff] removing temporary base worktree
[license-diff] comparing inventories
[license-diff] rendering Markdown output
[license-diff] done

Comment thread integrations/openclaw/src/hook-replay/tool.ts Outdated
Comment thread integrations/openclaw/src/hook-replay/skill-load.ts Outdated

Copy link
Copy Markdown
Contributor

I’d drop the OpenClaw-specific skill-load handling from this stack. With the CLI/sidecar pivot, extending hook replay with eager/fallback state looks like unnecessary complexity. I’d keep the shared core and other integration changes, remove the corresponding OpenClaw changes from 392/393, and handle managed OpenClaw skill marks at the sidecar boundary if we still need them. That would also make my OpenClaw-specific inline comments moot.

zhongxuanwang-nv and others added 2 commits July 10, 2026 09:30
UserPromptExpansion is only present in Claude Code's plugin hook
whitelist from 2.1.116. Older hosts reject the entire plugin hooks
file on the unknown event name and silently load no relay hooks,
for both the transparent-run temp plugin and the marketplace plugin.

Document the verified floor on HOOK_EVENTS, make doctor warn when the
probed Claude Code predates it, and state the requirement in the
plugin README.

Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
(cherry picked from commit d3b8959)
Signed-off-by: Will Killian <wkillian@nvidia.com>
@github-actions github-actions Bot removed the lang:js PR changes/introduces Javascript/Typescript code label Jul 10, 2026
@willkill07 willkill07 changed the title feat: detect skill loads in agent integrations [2/3] feat: add skill-load coverage for agent integrations [2/3] Jul 10, 2026
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature a new feature lang:python PR changes/introduces Python code lang:rust PR changes/introduces Rust code size:XL PR is extra large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants