Implement logical workers#236
Open
voegtlel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logical_workersin theWorkerConfig. This number may be less than the number of physical workers (=world_size * num_workers), but physical workers must be divisible by logical workers.logical_workers = physical_workers(old behavior)logical_workers = physical_workers / 4would result in 4 physical workers iterating the same data, but each with a stride of 4@skip_safeor@stateless(skip_safe=True)on functions in theTaskEncoder, resulting in not calling these functions when skipping samples (if the chain supports it).skip_safe.