Skip to content

feat(libsy): add routed client callbacks#26

Open
sabhatinas wants to merge 21 commits into
grclark/feat/libsy-routers-pocfrom
sabhatinas/libsy-callbacks
Open

feat(libsy): add routed client callbacks#26
sabhatinas wants to merge 21 commits into
grclark/feat/libsy-routers-pocfrom
sabhatinas/libsy-callbacks

Conversation

@sabhatinas

Copy link
Copy Markdown
Contributor

Summary

  • Add generic RouterCallback<D> hooks to the libsy routed-client loop.
  • Add RoutedClientBuilder::callback(...) so clients register callbacks once, independent of the selected algorithm.
  • Verify one callback implementation observes both random routing and LLM-classifier routing.

Validation

  • cargo test -p libsy
  • cargo fmt --all --check
  • cargo clippy -p libsy --all-targets -- -D warnings
  • git diff --check -- crates/libsy/src/client.rs crates/libsy/src/lib.rs

messiaen and others added 21 commits July 2, 2026 16:14
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
@nv-msvoboda

Copy link
Copy Markdown
Contributor

@sir-merge-a-lot groom

@nv-sir-merge-a-lot

nv-sir-merge-a-lot Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
Previous updates (collapsed)

🤖 sir-merge-a-lot

Resolving conflicts

🔄 sir-merge-a-lot is resolving conflicts on this MR.

Detected 2 conflicting file(s) (LOW). I'll update this comment with the result. This can take a couple of minutes.

🤖 sir-merge-a-lot

Merge analysis

Strategy: cherry_pick_with_resolution
Overall risk: LOW

Commits:

  • e42e33cf feat(libsy): add routed client callbacks

Conflicts:

File Type Risk
crates/libsy/src/client.rs modify/delete low
crates/libsy/src/lib.rs content low

Resolution ladder trace

Rung Result Details
Server-side rebase skipped Skipped because conflicts were detected during local analysis; GitLab rebase would not produce a clean branch. Files: crates/libsy/src/client.rs, crates/libsy/src/lib.rs
Client-side rebase skipped Skipped because conflicts were detected during local analysis; using the conflict-resolution ladder instead of force-pushing a conflicted rebase. Files: crates/libsy/src/client.rs, crates/libsy/src/lib.rs
Rerere miss No cached rerere resolution matched the remaining conflicts. Files: crates/libsy/src/client.rs, crates/libsy/src/lib.rs
Mergiraf resolved Mergiraf resolved conflicts structurally. Files: crates/libsy/src/client.rs
Mergiraf declined Mergiraf ran but left conflicts in the remaining files. Files: crates/libsy/src/lib.rs
LLM invoked Escalating remaining files to LLM for bounded LLM resolution. Files: crates/libsy/src/lib.rs
LLM failed LLM could not produce an accepted resolution for the remaining files. Failure reason: llm_timeout. Files: crates/libsy/src/lib.rs
Human escalation required Resolution ladder exhausted; human intervention is required. Files: crates/libsy/src/lib.rs

Final failure reason: llm_timeout.

Why now: I analyzed 2 conflict(s) on sabhatinas/libsy-callbacks against grclark/feat/libsy-routers-poc (trigger: groom).
What I checked: file-level risk classification (2 LOW); conflict shapes (1 content, 1 modify/delete); commit spread (2 source-commit touch(es) across 2 conflicted file(s) (1 source commit(s) total)). Automated resolution ladder steps are captured in the trace below.
What I changed: nothing - automated resolution did not update the branch; the ladder exhausted and this PR needs human intervention.
Recovery: N/A - branch unchanged.

📖 The resolution ladder · How strategy is selected

🤖 sir-merge-a-lot · why this happened? · pause / opt out · Updated 2026-07-09 18:47:06 UTC

@messiaen messiaen force-pushed the grclark/feat/libsy-routers-poc branch from 81c5d5c to 9261a09 Compare July 9, 2026 19:18
@messiaen messiaen requested a review from a team as a code owner July 9, 2026 19:18
@messiaen messiaen force-pushed the grclark/feat/libsy-routers-poc branch from 1df67dc to aa72aa0 Compare July 10, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants