ci: fix check_tier_skips early-return under set -e#4564
Open
svcnemo-autobot wants to merge 1 commit into
Open
Conversation
The `[ "$expect" != "true" ] && return` guard added in 6d5e924 is unsafe under `set -e`: when a tier IS expected the `[ ]` test exits non-zero and the `&&` short-circuit leaves the compound statement with a failing exit status, which can abort the step before the skip check runs. Use an explicit `if` block so the early return is robust under `set -e`.
Collaborator
Author
|
/ok to test 03183cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the fragile
[ "$expect" != "true" ] && returnguard introduced in 6d5e924 with an explicitifblock so the early return is safe underset -e -o pipefailin the CI summary job.