refactor(models): migrate AutoBridge to model builders#4545
Draft
yaoyu-33 wants to merge 18 commits into
Draft
Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 584017d |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Contributor
Author
|
/ok to test 10f4ab2 |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Contributor
Author
|
/ok to test a4421da |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 812b989 |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
yaoyu-33
commented
Jun 28, 2026
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test ac242e9 |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 54a17a8 |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 07662b2 |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 3ef284e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked follow-ups
Both follow-ups are based on this branch so the generic ModelConfig and ModelBuilder infrastructure remains centralized here.
Validation
uvx pre-commit run --all-filesexamplesnamespaceDeepSeek-V4 compatibility
DeepSeek-V4 has the same serializable config/builder contract as every other in-scope registration, with no provider fallback. The pinned Megatron-Core only exposes the
gated_delta_netanddsaexperimental attention variants and does not yet contain DSv4 CSA/mHC/hash-layer fields. Its builder therefore raises an actionable NotImplementedError instead of mutating an exact MCore config with phantom attributes or routing through a provider that cannot construct DSv4 on this pin either.Notes