Skip to content

[codex] Split sandbox unit tests in CI#1778

Open
hemildesai wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
hemildesai:codex/sandbox-unit-test-marker
Open

[codex] Split sandbox unit tests in CI#1778
hemildesai wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
hemildesai:codex/sandbox-unit-test-marker

Conversation

@hemildesai

@hemildesai hemildesai commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a sandbox pytest marker and apply it to the sandbox unit-test modules
  • keep ng_dev_test for the core unit-test run while selecting not sandbox via PYTEST_ADDOPTS
  • run sandbox unit tests in a separate pytest invocation
  • append sandbox coverage into the same report so the overall coverage gate still runs once
  • install the sandbox extra in the full-test-suite workflow so the marked sandbox tests have their optional dependencies
  • make CLI did-you-mean parsing handle argparse's unquoted choose from a, b format, which was blocking the split core test command locally

Validation

  • uv run pytest tests/unit_tests/test_cli_main.py::TestDidYouMean::test_mistyped_group tests/unit_tests/test_cli_main.py::TestDidYouMean::test_mistyped_action tests/unit_tests/test_cli_main.py::TestDidYouMean::test_mistyped_flag_choice -q
  • PYTEST_ADDOPTS='-m "not sandbox" --cov-report= --cov-fail-under=0' uv run ng_dev_test
  • uv run pytest --cov=. --cov-append --cov-report=term-missing --durations=10 -m sandbox
  • uv run pre-commit run --files .github/workflows/unit-tests.yml .github/workflows/full-test-suite.yml pyproject.toml nemo_gym/cli/main.py tests/unit_tests/test_sandbox.py tests/unit_tests/test_opensandbox_provider.py tests/unit_tests/test_apptainer_provider.py

@copy-pr-bot

copy-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai hemildesai force-pushed the codex/sandbox-unit-test-marker branch from b7cd805 to 5f24912 Compare June 26, 2026 16:29
@hemildesai hemildesai marked this pull request as ready for review June 26, 2026 16:49
@hemildesai hemildesai requested a review from a team as a code owner June 26, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant