feat(code_gen): add per-language subset metrics for livecodebench-x#1719
Open
rodboev wants to merge 3 commits into
Open
feat(code_gen): add per-language subset metrics for livecodebench-x#1719rodboev wants to merge 3 commits into
rodboev wants to merge 3 commits into
Conversation
Signed-off-by: Rod Boev <rod.boev@gmail.com>
…correctly Signed-off-by: Rod Boev <rod.boev@gmail.com>
…_dump Signed-off-by: Rod Boev <rod.boev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_metrics()currently groups bydifficultyonly. livecodebench-x benchmark rows include atarget_languagefield (de,es,fr,ja) as a top-level data row field (adjacent toverifier_metadata, not inside it), but the field was never declared onCompCodingVerifyRequest— Pydantic silently dropped it — and therefore never reachedCompCodingVerifyResponseorcompute_subset_metrics. As a result, per-language pass@k values never appear inrollouts_aggregate_metrics.json.This PR fixes that by mirroring the existing
difficultypattern:target_language: Optional[str] = NonetoCompCodingVerifyRequestso Pydantic preserves the top-level field through routingtarget_language: Optional[str] = NonetoCompCodingVerifyResponsebody.target_languageinverify()and propagates it through all three return sites via**body.model_dump()compute_subset_metrics(tasks, "target_language", ...)alongside the existing difficulty callget_key_metrics()already handles the new prefixes generically — no change needed thereCloses #1171
Checklist
uv run pytest resources_servers/code_gen/tests/test_app.py -x -vnemo_gym/reward_profile.py