Skip to content

fix: add missing chat error response helper#58

Merged
rmkraus merged 1 commit into
NVIDIA-AI-Blueprints:stagingfrom
rmkraus:rkraus/fix-error-chat-response-helper
Jun 23, 2026
Merged

fix: add missing chat error response helper#58
rmkraus merged 1 commit into
NVIDIA-AI-Blueprints:stagingfrom
rmkraus:rkraus/fix-error-chat-response-helper

Conversation

@rmkraus

@rmkraus rmkraus commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add the missing _create_error_chat_response helper used by chat error paths
  • Add regression coverage that checks locally-called _create_* helpers in chat.py are defined

Verification

  • python3 -m py_compile src/api/routers/chat.py tests/unit/test_chat_router_private_helpers.py
  • python3 -m unittest tests.unit.test_chat_router_private_helpers -v
  • git diff --check

Closes #30

@rmkraus rmkraus changed the base branch from main to staging June 23, 2026 17:50
@rmkraus rmkraus force-pushed the rkraus/fix-error-chat-response-helper branch from 73de884 to d5f10ca Compare June 23, 2026 17:50
@rmkraus rmkraus merged commit 7ff857c into NVIDIA-AI-Blueprints:staging Jun 23, 2026
6 of 8 checks passed
@rmkraus rmkraus deleted the rkraus/fix-error-chat-response-helper branch June 23, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] FUNC _create_error_chat_response undefine

1 participant