Feature/fetch_CDSE update - #8
Open
jerrychlun wants to merge 36 commits into
Open
Conversation
YenCheng1226
requested changes
Jan 19, 2026
YenCheng1226
left a comment
YenCheng1226
left a comment
Collaborator
There was a problem hiding this comment.
核心的event process 和save 大致沒有問題，但有一些bug 需要修正，再麻煩仔細看一下。另外這裡應該不用處理 event list 的input，下次開會會一起討論修正這塊
Comment on lines
+208
to
+214
| start_dt = datetime.strptime(event["start_date"], "%Y-%m-%d") | ||
| end_dt = datetime.strptime(event["end_date"], "%Y-%m-%d") | ||
| full_start = start_dt - timedelta(days=int(event["pre_event_days"])) | ||
| full_end = end_dt + timedelta(days=int(event["post_event_days"])) | ||
| date_range = ( | ||
| f"{full_start.strftime('%Y-%m-%d')}/{full_end.strftime('%Y-%m-%d')}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
這邊應該是 ingestion.py 要做的事，下次會議會一起討論這部分
YenCheng1226
requested changes
Jan 19, 2026
YenCheng1226
left a comment
YenCheng1226
left a comment
Collaborator
There was a problem hiding this comment.
大致的process 和save 沒有問題，但有一些bu師，vum 要修正，再麻煩仔細看一下 comments 。
另外event list 轉datetime，我在思考怎麼跟ingestion.py 整合會最有效率，應該可以不需要在這裡parse。
YenCheng1226
requested changes
Jan 20, 2026
YenCheng1226
left a comment
YenCheng1226
left a comment
Collaborator
There was a problem hiding this comment.
bug fix and performance optimization
jerrychlun
commented
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
金鑰.env.example需要建立與討論。
ingestion而來的input需要確認。
fetch_CDSE的output也需要細節確認。
目前先skip掉csv儲存在data/的pytest。
流程細節待建立。