Skip to content

[codex] Expose basic PGN import API#30

Merged
NSStudent merged 1 commit into
developfrom
codex/public-basic-pgn-import
May 15, 2026
Merged

[codex] Expose basic PGN import API#30
NSStudent merged 1 commit into
developfrom
codex/public-basic-pgn-import

Conversation

@NSStudent

Copy link
Copy Markdown
Owner

Summary

Expose the lightweight BasicPGN import path so external consumers can parse PGN metadata and raw movetext efficiently.

Changes

  • Make BasicPGNParser public and add BasicPGNReader as the simple public entry point.
  • Add Equatable, Sendable, Codable, and convenience tag accessors to BasicPGNGame.
  • Preserve custom tags explicitly and support escaped PGN tag values in TagParser.
  • Add public API tests without @testable import covering custom tags, escaped values, multi-game parsing, and Codable round-tripping.

Validation

  • rtk swift build
  • rtk swift test --filter BasicPGNPublicAPITests
  • rtk swift test --filter PGN
  • rtk swift test

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.34615% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Sources/FischerCore/PGN/Parsers/TagParser.swift 86.95% 9 Missing ⚠️
Files with missing lines Coverage Δ
Sources/FischerCore/PGN/Model/BasicPGNGame.swift 100.00% <100.00%> (ø)
...urces/FischerCore/PGN/Parsers/BasicPGNParser.swift 100.00% <100.00%> (ø)
Sources/FischerCore/PGN/Parsers/TagParser.swift 86.95% <86.95%> (-13.05%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NSStudent NSStudent marked this pull request as ready for review May 15, 2026 10:01
@NSStudent NSStudent merged commit 06129a4 into develop May 15, 2026
3 checks passed
@NSStudent NSStudent deleted the codex/public-basic-pgn-import branch May 15, 2026 10:01
NSStudent added a commit that referenced this pull request May 15, 2026
feat(pgn): expose basic PGN import API (#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant