Skip to content

fix: improve frontend accessibility roles#709

Open
kimanicode wants to merge 1 commit into
NOVUS-X:mainfrom
kimanicode:fix/589-accessibility-audit-aria-roles
Open

fix: improve frontend accessibility roles#709
kimanicode wants to merge 1 commit into
NOVUS-X:mainfrom
kimanicode:fix/589-accessibility-audit-aria-roles

Conversation

@kimanicode

@kimanicode kimanicode commented Apr 29, 2026

Copy link
Copy Markdown

Closes #589


Summary

Addresses #589 by improving frontend accessibility semantics and ARIA coverage across key app flows.

  • Adds labelled dialog semantics to matchmaking, searching, reconnecting, and puzzle reward modals
  • Adds Escape-key close support for the AI personality modal
  • Marks AI personality choices with aria-pressed and descriptive accessible names
  • Converts puzzle cards from clickable div role="button" elements to native buttons
  • Cleans status/reward text so screen readers announce readable content
  • Fixes invalid nested content inside game mode buttons
  • Adds local react-icons type declarations so frontend typechecks cleanly

Tests

  • Added ARIA-focused tests for AiPersonalityModal
  • npx tsc --noEmit --pretty false passes

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@kimanicode has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 53 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a82cd27-8845-409f-9c2f-3b0412c1f949

📥 Commits

Reviewing files that changed from the base of the PR and between 8f92605 and ced507f.

📒 Files selected for processing (7)
  • frontend/__tests__/AiPersonalityModal.test.tsx
  • frontend/app/components/matchmaking/AiPersonalityModal.tsx
  • frontend/app/layout.tsx
  • frontend/app/page.tsx
  • frontend/app/puzzles/page.tsx
  • frontend/components/GameModeButtons.tsx
  • frontend/types/react-icons.d.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 31 minutes and 53 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@drips-wave

drips-wave Bot commented Apr 29, 2026

Copy link
Copy Markdown

@kimanicode Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend: Accessibility audit and ARIA roles

1 participant