Skip to content

Fre list datasets#902#923

Draft
kiihne-noaa wants to merge 6 commits into
NOAA-GFDL:mainfrom
kiihne-noaa:fre_list_datasets#902
Draft

Fre list datasets#902#923
kiihne-noaa wants to merge 6 commits into
NOAA-GFDL:mainfrom
kiihne-noaa:fre_list_datasets#902

Conversation

@kiihne-noaa

Copy link
Copy Markdown
Contributor

Describe your changes

Issue ticket number and link (if applicable)

Fixes #XXX (replace XXX with the issue number and GitHub will autolink the PR to the issue)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

This function returns a list of absolute paths to data sets within yaml file.
Add test for list_datasets_script.py using a temporary YAML file.
Refactor test function to improve naming and structure.
Update assertion for list_datasets_subtool function call.
Remove temporary YAML file after execution.
@kiihne-noaa

Copy link
Copy Markdown
Contributor Author

@singhd789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant